Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move MasterUpgrade() out from e2e framework #93081

Merged
merged 1 commit into from Aug 28, 2020
Merged

Move MasterUpgrade() out from e2e framework #93081

merged 1 commit into from Aug 28, 2020

Conversation

oomichi
Copy link
Member

@oomichi oomichi commented Jul 14, 2020

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

MasterUpgrade() is called only from cloud/gcp/cluster_upgrade.go.
And the function depends on GCP, so it is nice to move this function from e2e framework.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework label Jul 14, 2020
@k8s-ci-robot k8s-ci-robot added area/test approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 14, 2020
@oomichi
Copy link
Member Author

oomichi commented Jul 14, 2020

/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 14, 2020
@oomichi
Copy link
Member Author

oomichi commented Jul 15, 2020

/retest

tanjunchen
tanjunchen approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@tanjunchen tanjunchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oomichi
/lgtm
/thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2020
@oomichi
Copy link
Member Author

oomichi commented Jul 16, 2020

need to update this after #92349

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2020
Move MasterUpgrade() out from e2e framework
80c19e4 
MasterUpgrade() is called only from cloud/gcp/cluster_upgrade.go.
And the function depends on GCP, so it is nice to move this function
from e2e framework.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2020
@oomichi
Copy link
Member Author

oomichi commented Jul 17, 2020

Rebase is complete:

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2020
@oomichi
Copy link
Member Author

oomichi commented Jul 17, 2020

/retest

@oomichi
Copy link
Member Author

oomichi commented Jul 17, 2020

/test pull-kubernetes-node-e2e

@oomichi
Copy link
Member Author

oomichi commented Jul 18, 2020

/test pull-kubernetes-e2e-gce-device-plugin-gpu

4 similar comments
@oomichi
Copy link
Member Author

oomichi commented Jul 18, 2020

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@oomichi
Copy link
Member Author

oomichi commented Jul 19, 2020

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@oomichi
Copy link
Member Author

oomichi commented Jul 20, 2020

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@oomichi
Copy link
Member Author

oomichi commented Jul 20, 2020

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@oomichi oomichi mentioned this pull request Jul 21, 2020
Closed
alejandrox1
alejandrox1 reviewed Jul 24, 2020
View reviewed changes
Copy link
Contributor

@alejandrox1 alejandrox1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2020
@alejandrox1 alejandrox1 added this to Reviewer approved in Testing Commons Jul 24, 2020
@justaugustus justaugustus added this to the v1.20 milestone Aug 27, 2020
@justaugustus
Copy link
Member

/test pull-kubernetes-e2e-kind-ipv6

@k8s-ci-robot k8s-ci-robot merged commit db99166 into kubernetes:master Aug 28, 2020
Testing Commons automation moved this from Reviewer approved to Done Aug 28, 2020
@oomichi oomichi deleted the MasterUpgradeGKE branch October 14, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrox1 alejandrox1 alejandrox1 left review comments

@tanjunchen tanjunchen tanjunchen approved these changes

@cheftako cheftako Awaiting requested review from cheftako

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@alejandrox1 alejandrox1

@tanjunchen tanjunchen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
No open projects
Testing Commons
  
Done
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@oomichi @k8s-ci-robot @justaugustus @alejandrox1 @tanjunchen