Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix providerless kubelet startup #93607

Merged
merged 1 commit into from Aug 2, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/kubelet/app/options/BUILD
Expand Up @@ -13,6 +13,7 @@ go_library(
"globalflags.go",
"globalflags_linux.go",
"globalflags_other.go",
"globalflags_providers.go",
"options.go",
"osflags_others.go",
"osflags_windows.go",
Expand Down
4 changes: 1 addition & 3 deletions cmd/kubelet/app/options/globalflags.go
Expand Up @@ -84,9 +84,7 @@ func addCredentialProviderFlags(fs *pflag.FlagSet) {
global := pflag.CommandLine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: no need to get global here and pass to addLegacyCloudProviderCredentialProviderFlags . It can be taken when needed.

local := pflag.NewFlagSet(os.Args[0], pflag.ExitOnError)

// TODO(#58034): This is not a static file, so it's not quite as straightforward as --google-json-key.
// We need to figure out how ACR users can dynamically provide pull credentials before we can deprecate this.
pflagRegister(global, local, "azure-container-registry-config")
addLegacyCloudProviderCredentialProviderFlags(global, local)

fs.AddFlagSet(local)
}
Expand Down
27 changes: 27 additions & 0 deletions cmd/kubelet/app/options/globalflags_providerless.go
@@ -0,0 +1,27 @@
// +build providerless

/*
Copyright 2020 The Kubernetes Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package options

import (
"github.com/spf13/pflag"
)

func addLegacyCloudProviderCredentialProviderFlags(global, local *pflag.FlagSet) {
// no-op when no legacy providers are compiled in
}
29 changes: 29 additions & 0 deletions cmd/kubelet/app/options/globalflags_providers.go
@@ -0,0 +1,29 @@
// +build !providerless

/*
Copyright 2020 The Kubernetes Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package options

import (
"github.com/spf13/pflag"
)

func addLegacyCloudProviderCredentialProviderFlags(global, local *pflag.FlagSet) {
// TODO(#58034): This is not a static file, so it's not quite as straightforward as --google-json-key.
// We need to figure out how ACR users can dynamically provide pull credentials before we can deprecate this.
pflagRegister(global, local, "azure-container-registry-config")
liggitt marked this conversation as resolved.
Show resolved Hide resolved
}