Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e services wait for endpoint and endpoint slices #93829

Merged
merged 1 commit into from Aug 12, 2020
Merged

e2e services wait for endpoint and endpoint slices #93829

merged 1 commit into from Aug 12, 2020

Conversation

aojea
Copy link
Member

@aojea aojea commented Aug 9, 2020

Since 1.19 endpoint slices is enabled by default, so all the e2e
tests should consider them.

Similar to #93597

I also found another test that need to be adapted
k8s.io/kubernetes/test/e2e/network/service_latency.go

kubernetes/test/e2e/network/service_latency.go

Line 295 in 62b8fae

func startEndpointWatcher(f *framework.Framework, q *endpointQueries) { 

NONE

/kind flake

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 9, 2020
@aojea
Copy link
Member Author

aojea commented Aug 9, 2020

/assign @liggitt @wojtek-t
/cc @robscott

@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 9, 2020
@aojea
Copy link
Member Author

aojea commented Aug 9, 2020 •
edited

[sig-cli] Kubectl client Kubectl client-side validation should create/apply a CR with unknown fields for CRD with no validation schema expand_less | 1m16s

test/e2e/kubectl/kubectl.go:1004 Aug 9 10:57:43.854: failed to create CR {"kind":"E2e-test-kubectl-2128-crd","apiVersion":"kubectl.example.com/v1","metadata":{"name":"test-cr"},"a":{"b":[{"c":"d"}]}} in namespace --namespace=kubectl-8200: error running /home/prow/go/src/k8s.io/kubernetes/bazel-bin/cmd/kubectl/linux_amd64_pure_stripped/kubectl --server=https://127.0.0.1:35115 --kubeconfig=/root/.kube/kind-test-config --namespace=kubectl-8200 create --validate=true -f -: Command stdout: stderr: Unable to connect to the server: context deadline exceeded (Client.Timeout exceeded while awaiting headers) error: exit status 1

@aojea
Copy link
Member Author

aojea commented Aug 9, 2020

/retest

hasheddan
hasheddan reviewed Aug 10, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/milestone v1.19

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 10, 2020
wojtek-t
wojtek-t reviewed Aug 11, 2020
View reviewed changes
test/e2e/framework/service/jig.go Outdated Show resolved Hide resolved
test/e2e/framework/service/jig.go Show resolved Hide resolved
e2e services wait for endpoint and endpoint slices
f31839a 
Since 1.19 endpoint slices is enabled by default, so all the e2e
tests should consider them.

The e2e networking tests for services use the jig object for
all the tests, but was not taking into account endpoint slices.

This considers endpoints slices for the method waitForAvailableEndpoint()

 Date:      Sun Aug 9 12:34:06 2020 +0200
@wojtek-t
Copy link
Member

We can improve that further, but that's already net improvement. So let's make it.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit c780554 into kubernetes:master Aug 12, 2020
@spiffxp spiffxp mentioned this pull request Aug 13, 2020
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@hasheddan hasheddan hasheddan left review comments

@robscott robscott Awaiting requested review from robscott

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@liggitt liggitt

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aojea @wojtek-t @k8s-ci-robot @robscott @hasheddan @liggitt