Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote spiffxp to build/ approver #93935

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Promote spiffxp to build/ approver #93935

merged 1 commit into from
Aug 12, 2020

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 12, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Promote spiffxp to build/ approver

I've been a reviewer here for nearly 2 years, and am now part of the team
that builds the google-hosted .dep and .rpm packages

Special notes for your reviewer:
I plan on cherry-picking this back to other release branches

Does this PR introduce a user-facing change?:

NONE

@spiffxp
Promote spiffxp to build/ approver
e056241 
I've been a reviewer here for nearly 2 years, and am now part of
the team that builds the google-hosted .dep and .rpm packages
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 12, 2020
@BenTheElder
Copy link
Member

/approve
/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Aug 12, 2020 •
edited

PR's reviewed recently:

@spiffxp spiffxp mentioned this pull request Aug 12, 2020
Closed
@justaugustus
Copy link
Member

/lgtm
/approve

@spiffxp
Copy link
Member Author

spiffxp commented Aug 12, 2020

/assign @cblecker @justaugustus @dims

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, justaugustus, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Member

/hold cancel
(approved by two build/ approvers)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Aug 12, 2020

/milestone v1.19

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 12, 2020
@cblecker
Copy link
Member

/lgtm

@spiffxp
Copy link
Member Author

spiffxp commented Aug 12, 2020

/priority important-soon
/sig testing
/sig release

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 12, 2020
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1e8f7a9 into kubernetes:master Aug 12, 2020
@spiffxp spiffxp deleted the make-spiffxp-build-approver branch August 12, 2020 19:19
This was referenced Aug 12, 2020
Merged
Merged
Merged
Closed
@spiffxp
Copy link
Member Author

spiffxp commented Aug 12, 2020

Opened cherry picks to other release branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta Awaiting requested review from fejta

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@dims dims

@justaugustus justaugustus

@BenTheElder BenTheElder

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@spiffxp @BenTheElder @justaugustus @k8s-ci-robot @cblecker @dims