Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to etcd client version 3.4.12 #94105

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Update to etcd client version 3.4.12 #94105

merged 1 commit into from
Aug 19, 2020

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Aug 19, 2020

What type of PR is this?

/kind bug

What this PR does / why we need it:

Updates to etcd client library 3.4.12:

Does this PR introduce a user-facing change?:

NONE

/area etcd
/cc @jingyih
/sig api-machinery
/milestone v1.19

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/etcd labels Aug 19, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 19, 2020
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 19, 2020
This was referenced Aug 19, 2020
Closed
Closed
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Aug 19, 2020
@liggitt
Copy link
Member Author

liggitt commented Aug 19, 2020

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 19, 2020
@liggitt
Copy link
Member Author

liggitt commented Aug 19, 2020

/cc @gyuho

@jingyih
Copy link
Contributor

jingyih commented Aug 19, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2020
@dims
Copy link
Member

dims commented Aug 19, 2020

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jingyih
Copy link
Contributor

jingyih commented Aug 19, 2020

cc @kubernetes/release-engineering

@BenTheElder
Copy link
Member

will we also update the server?

@liggitt
Copy link
Member Author

liggitt commented Aug 19, 2020

will we also update the server?

no, we're sticking with 3.4.9 until etcd-io/etcd#12144 / etcd-io/etcd#12148 are resolved

@k8s-ci-robot k8s-ci-robot merged commit dd3d66b into kubernetes:master Aug 19, 2020
@BenTheElder
Copy link
Member

Those two issues appear to be closed with only a changelog update? Is there somewhere better to track the resolution?

@liggitt
Copy link
Member Author

liggitt commented Aug 19, 2020

hmm... @jingyih, any suggestions?

@BenTheElder
Copy link
Member

BenTheElder commented Aug 19, 2020 •
edited
Loading

related #94102 / kubernetes/kubeadm#2256

@gyuho
Copy link
Member

gyuho commented Aug 19, 2020

/lgtm thank you.

@liggitt liggitt deleted the etcd-3.4.12 branch August 25, 2020 12:30
@BenTheElder BenTheElder mentioned this pull request Aug 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingyih jingyih Awaiting requested review from jingyih

@gyuho gyuho Awaiting requested review from gyuho

Assignees

@dims dims

@jingyih jingyih

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/etcd cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
6 participants
@liggitt @jingyih @dims @k8s-ci-robot @BenTheElder @gyuho