Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify DNS-1123 error messages to indicate that RFC 1123 is not followed exactly #94182

Merged
merged 1 commit into from
Sep 2, 2020
Merged

modify DNS-1123 error messages to indicate that RFC 1123 is not followed exactly #94182

merged 1 commit into from
Sep 2, 2020

Conversation

mattfenwick
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #94088

Special notes for your reviewer:

Based on #94088 (comment) .

Does this PR introduce a user-facing change?:

modify DNS-1123 error messages to indicate that RFC 1123 is not followed exactly

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 23, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @mattfenwick. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 23, 2020
@jayunit100
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 23, 2020
@jayunit100
Copy link
Member

/sig network

@jayunit100
Copy link
Member

/release-note-none

@k8s-ci-robot
Copy link
Contributor

@jayunit100: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to this:

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jayunit100
Copy link
Member

@mattfenwick check https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/admissionregistration/validation/validation_test.go those tests are failing

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 24, 2020
@mattfenwick
Copy link
Contributor Author

/retest

1 similar comment
@mattfenwick
Copy link
Contributor Author

/retest

@mattfenwick
Copy link
Contributor Author

mattfenwick commented Aug 24, 2020 •
edited
Loading

Looks like the failing tests are flakes and unrelated to my changes @jayunit100 -- what's the standard way to deal with flakes in k8s tests?

@mattfenwick
Copy link
Contributor Author

Looks like the flakes this PR is experiencing are the same as those reported in #93609.

@jayunit100
Copy link
Member

/test pull-kubernetes-integration

@neolit123
Copy link
Member

please keep the commits squashed to one.
i'm +1 for some sort of indication about this, mainly because i've seen a number of tickets asking why the underlying utility is not following the standard exactly.

@mattfenwick mattfenwick force-pushed the issue-94088 branch 4 times, most recently from b1bda41 to 8000f2d Compare August 31, 2020 18:08
@mattfenwick
Copy link
Contributor Author

/retest

@liggitt
Copy link
Member

liggitt commented Sep 2, 2020

/lgtm
/approve

@liggitt
Copy link
Member

liggitt commented Sep 2, 2020

/priority backlog
/milestone v1.20

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Sep 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 2, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Sep 2, 2020
@liggitt
Copy link
Member

liggitt commented Sep 2, 2020

thanks for the updates

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jayunit100, liggitt, mattfenwick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit e077b0f into kubernetes:master Sep 2, 2020
@github-actions github-actions bot mentioned this pull request Sep 3, 2020
Open
@neolit123 neolit123 mentioned this pull request Sep 15, 2020
Closed
@mattfenwick mattfenwick mentioned this pull request Dec 30, 2020
Closed
6 tasks
@mattfenwick mattfenwick deleted the issue-94088 branch January 5, 2021 17:23
@yaooqinn yaooqinn mentioned this pull request May 21, 2021
Closed
@atsikham atsikham mentioned this pull request Nov 3, 2021
Merged
@mattfenwick mattfenwick mentioned this pull request Sep 30, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

@mikedanese mikedanese Awaiting requested review from mikedanese

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@lavalamp lavalamp

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

RFC1123 is incorrectly enforced
8 participants
@mattfenwick @k8s-ci-robot @jayunit100 @neolit123 @fedebongio @liggitt @fejta-bot @lavalamp