Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Make web ui build robust and reproducible. #9438

Closed
wants to merge 1 commit into from

Conversation

jackgr
Copy link
Contributor

@jackgr jackgr commented Jun 8, 2015

This PR contains only the build script portions of #8776. It is part of the UI cleanup requested by #7122.

It does the following:

  • Adds hack/www/build-www.sh to invoke the www directory build.
  • Adds a node based container based to make the www directory build reproducible.
  • Adds build/www/run.sh to run hack/www/build-www.sh in the container.
  • Moves the generation of pkg/ui/datafile.go from the www directory build output into library functions.
  • Makes hack/build-cross.sh and hack/build-go.sh call the library functions, so that the output of the www directory build is picked up by the go build.
  • Makes build/release.sh build the whole UI, including the www directory and pkg/ui/datafile.go.
  • Adds lines to .travis.yml and shippable.yml to make them build the whole UI.

This PR is marked as WIP because it contains changes to the go build processes. While care has been taken to follow the "gold standard" of shell code in every modification, except those that were straight copies of existing code, errors in this PR could break the build.

cc @bgrant0607, @thockin, @bcbroussard, @preillyme

@k8s-bot
Copy link

k8s-bot commented Jun 8, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@bcbroussard
Copy link
Contributor

@jackgr - Just a heads up that #8639 and #8659 will change the travis and shippable configs a bit

@jackgr jackgr force-pushed the ui_build_scripts branch 10 times, most recently from b4058b4 to d16177d Compare June 9, 2015 23:04
@k8s-bot
Copy link

k8s-bot commented Jun 10, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@jackgr jackgr force-pushed the ui_build_scripts branch 8 times, most recently from d5cc86d to 1dbdf72 Compare June 22, 2015 02:03
@j3ffml
Copy link
Contributor

j3ffml commented Jun 22, 2015

Assigning to @bgrant0607 for milestone triage.

@j3ffml j3ffml added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jun 22, 2015
@jackgr jackgr force-pushed the ui_build_scripts branch 3 times, most recently from 613d371 to 781dde3 Compare June 25, 2015 03:45
@jackgr
Copy link
Contributor Author

jackgr commented Jun 30, 2015

When #10077, the UI will no longer be built in the main repo. This PR will then no longer be needed.

@jackgr jackgr closed this Jun 30, 2015
@jackgr jackgr deleted the ui_build_scripts branch October 26, 2015 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants