kubeadm: apply resource requests in the etcd pod spec #94479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
/cc @neolit123 |
k8s-ci-robot
added
priority/backlog
knight42
commented
Sep 3, 2020
neolit123
reviewed
Sep 3, 2020
cmd/kubeadm/app/phases/etcd/local.go
Outdated
| @@ -247,6 +248,14 @@ func GetEtcdPodSpec(cfg *kubeadmapi.ClusterConfiguration, endpoint *kubeadmapi.A | |||
| staticpodutil.NewVolumeMount(etcdVolumeName, cfg.Etcd.Local.DataDir, false), | |||
| staticpodutil.NewVolumeMount(certsVolumeName, cfg.CertificatesDir+"/etcd", false), | |||
| }, | |||
| Resources: v1.ResourceRequirements{ | |||
| Requests: v1.ResourceList{ | |||
| // TODO: make these values configurable | |||
There was a problem hiding this comment.
please remove this TODO for now.
users can use the --experimental-patches functionality to apply patches during init/join/upgrade.
the patches feature can one day be in the kubeadm config too.
neolit123
reviewed
Sep 3, 2020
|
/retitle kubeadm: apply resource requests in the etcd pod spec |
k8s-ci-robot
changed the title
|
/cc @rosti @ereslibre |
|
/hold for review |
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knight42, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: knight42 <anonymousknight96@gmail.com>
knight42
force-pushed
the
feat/kubeadm-etcd-pod-resource-requests
branch
from
cc073f9
to
2ebd293
Compare
|
/retest |
|
we didn't get immediate objections on kubernetes/kubeadm#2195 so let's see how this goes. /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: knight42 anonymousknight96@gmail.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes kubernetes/kubeadm#2195
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: