Upgrade examples/guestbook to v1 #9455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EXPERIMENTAL JENKINS PR BUILDER: e2e build succeeded. |
|
@caesarxuchao I will take a look tomorrow. |
|
I will update guest-go after this one has been reviewed |
caesarxuchao
force-pushed
the
guestbook-example-v1
branch
from
5db6f2b
to
39382b2
Compare
|
EXPERIMENTAL JENKINS PR BUILDER: e2e build succeeded. |
|
|
||
| Thus, once created, the service proxy on each minion is configured to set up a proxy on the specified port (in this case port 6379). | ||
|
|
||
| *targetPort* will default to *port* if it is omitted in the configuration. For simplicity's sake, we omit it in the following configurations. |
There was a problem hiding this comment.
You say "following configurations" here, but you omit it in the previous one as well. Maybe just don't say "following."
krousey
added
the
lgtm
ArtfulCoder
added a commit
that referenced
this pull request
Jun 10, 2015
Upgrade examples/guestbook to v1
|
GCE e2e build/test passed for commit 39382b2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the example to v1;
Removed some default fields from the configuration files;
Update the description about load balancers and public IPs. (Reviewers: please take special care of this part as it's a quite big change)
ref #9286
@krousey @nikhiljindal @bgrant0607