Add a test that verifies pods with resource limits schedule. #9514
Conversation
|
EXPERIMENTAL JENKINS PR BUILDER: e2e build succeeded. |
|
EXPERIMENTAL JENKINS PR BUILDER: e2e build succeeded. |
|
Please comment, but don't merge this, I'm parallelizing getting a review, and validating the e2e passes. |
|
EXPERIMENTAL JENKINS PR BUILDER: e2e build succeeded. |
|
Ok, this passed e2e. ready for review and merge. |
|
EXPERIMENTAL JENKINS PR BUILDER: e2e build succeeded. |
| @@ -155,6 +156,42 @@ var _ = Describe("Pods", func() { | |||
| }, | |||
| }) | |||
| }) | |||
| It("should be schedule with cpu and memory limits", func() { | |||
| podClient := c.Pods(api.NamespaceDefault) | |||
There was a problem hiding this comment.
nit: Needs to run in it's own namespace using @lavalamp's Framework. But that's not how pods.go is wired up right now, so lets defer that to a separate PR.
|
LGTM |
ghost
added
the
lgtm
|
@brendandburns shippable is complaining about gofmt on pods.go |
|
LGTM thanks! |
|
@quinton-hoole added a TODO to convert to the framework stuff ptal. Thanks |
|
EXPERIMENTAL JENKINS PR BUILDER: e2e build succeeded. |
|
@timothysc acknowledged, but it covers a gap that we had, and we can expand from here. |
Add a test that verifies pods with resource limits schedule.
|
GCE e2e build/test passed for commit 3b034a8. |
@zmerlynn @quinton-hoole @dchen1107