Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If image has stack driver agent installed, use it. #95890

Merged
merged 1 commit into from Oct 29, 2020
Merged

If image has stack driver agent installed, use it. #95890

merged 1 commit into from Oct 29, 2020

Conversation

barney-s
Copy link
Contributor

Check if stackdriver agent is preinstalled in the image. If so configure and use it.
Else check for fluentbit agent

What type of PR is this?

/kind regression

What this PR does / why we need it:

This PR allows the startup scripts to work with images that have stackdriver agent installed.
If not it falls back to using fluentbit agent (install if needed).

Special notes for your reviewer:

Follow up to #93912

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/regression Categorizes issue or PR as related to a regression from a prior release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 27, 2020
@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 27, 2020
@pjh
Copy link
Contributor

pjh commented Oct 27, 2020

/cc @jeremyje @lizhuqi

@k8s-ci-robot
Copy link
Contributor

@pjh: GitHub didn't allow me to request PR reviews from the following users: jeremyje, lizhuqi.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @jeremyje @lizhuqi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pjh
Copy link
Contributor

pjh commented Oct 27, 2020

cc @jeremyje @lizhuqi

@pjh
Copy link
Contributor

pjh commented Oct 27, 2020

/priority important-soon
/triaged

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 27, 2020
@pjh
Copy link
Contributor

pjh commented Oct 27, 2020

/test pull-kubernetes-e2e-windows-gce

@pjh
Copy link
Contributor

pjh commented Oct 27, 2020

Thanks, I like this approach!

/lgtm
/approve
/hold

Please check the pull-kubernetes-e2e-windows-gce test job in a little while, if the nodes come up successfully then unhold this to merge.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2020
@pjh
Copy link
Contributor

pjh commented Oct 27, 2020

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 27, 2020
@barney-s
If image has stackdriver agent installed, use it.
73916e5 
Check if stackdriver agent is preinstalled in the image. If so configure and use it.
Else check for fluentbit agent
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2020
@pjh
Copy link
Contributor

pjh commented Oct 29, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barney-s, pjh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pjh
Copy link
Contributor

pjh commented Oct 29, 2020

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2020
@pjh
Copy link
Contributor

pjh commented Oct 29, 2020

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 29, 2020 •
edited

@barney-s: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-windows-gce 5f26910b7e998f44d89422e0bea33310f6307eb8 link /test pull-kubernetes-e2e-windows-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 7a20fcf into kubernetes:master Oct 29, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjh pjh Awaiting requested review from pjh

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@pjh pjh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@barney-s @pjh @k8s-ci-robot @fejta-bot