New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests to check metrics labels #96045
Conversation
Welcome @leilajal! |
Hi @leilajal. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc @logicalhan |
/assign |
/assign @logicalhan |
/uncc |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The additional tests seem good for me.
Just comments about error messages, that seems copy&paste mistakes.
/cc @oomichi
Thanks for updating. /lgtm |
/triage accepted |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leilajal, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/ kind bug
What this PR does / why we need it:
Adding more comprehensive test for mapping url paths to metrics labels
Which issue(s) this PR fixes:
Fixes #95636
Special notes for your reviewer:
Tests get a baseline of the current metrics, then using test tables to perform various pod and namespace operations. After the operation completes, we get the new generated metric, and compare it to a string representation of the desired metric in the test case.
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: