Update to heapster v0.14.0 #9615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ hack/ginkgo-e2e.sh --ginkgo.focus="Monitoring"
Monitoring
should verify monitoring pods and all cluster nodes are available on influxdb using heapster.
/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/monitoring.go:51
[BeforeEach] Monitoring
/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/monitoring.go:42
>>> testContext.KubeConfig: /usr/local/google/home/vishnuk/.kube/config
[It] should verify monitoring pods and all cluster nodes are available on influxdb using heapster.
/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/monitoring.go:51
Ran 1 of 73 Specs in 0.933 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 72 Skipped PASS |
|
cc @dchen1107 |
|
LGTM |
saad-ali
added
the
lgtm
| @@ -0,0 +1,13 @@ | |||
| kind: "Service" | |||
| apiVersion: "v1beta3" | |||
|
@lavalamp: Can the update to 'v1' be done in a separate PR for all the config files? |
|
I suggested not. What is blocking you to change those to v1 instead of v1beta3? |
|
Ok! All the monitoring configs have been updated. PTAL |
|
E2e passed again with updated configs: Monitoring
should verify monitoring pods and all cluster nodes are available on influxdb using heapster.
/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/monitoring.go:51
[BeforeEach] Monitoring
/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/monitoring.go:42
>>> testContext.KubeConfig: /usr/local/google/home/vishnuk/.kube/config
[It] should verify monitoring pods and all cluster nodes are available on influxdb using heapster.
/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/monitoring.go:51
•SSSSSSSSSSSSSSSSSSSSS
Ran 1 of 73 Specs in 0.857 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 72 Skipped PASS
Ginkgo ran 1 suite in 6.28581304s
Test Suite Passed |
|
This LGTM now, but I wonder why the "-v2" is needed in the name--is the label not sufficient? |
|
@lavalamp: The version labels were meant for rolling updates of addons during cluster upgrades. cc @satnam6502 to make sure I am satisfying the original design goals. |
|
LGTM thanks! |
|
Looks great to me. |
|
@ArtfulCoder: This PR needs to go in soon. Can you prioritize this? |
ArtfulCoder
added a commit
that referenced
this pull request
Jun 11, 2015
Update to heapster v0.14.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.