-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nvidia-gpu-device-plugin addon image path #96276
Conversation
@ruiwen-zhao: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @ruiwen-zhao. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig node |
/ok-to-test /assign @dims |
The error does not seem to be relevant. And there is already effort fixing it: #96274
|
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, ruiwen-zhao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Huh? gcr.io/google_containers was deprecated, k8s.gcr.io is the defacto Kubernetes OSS release registry. k8s.gcr.io is NOT deprecated |
sorry that was a typo. Yeah gcr.io/google_containers was deprecated but k8s.gcr.io was not. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
As part of the Vanity Domain Flip, the old image registry (
k8s.gcr.io
) is deprecated. This PR moves the image path to a new registry. Note that the new image is still built from the same commit as the old one, so there is no functionality change.Which issue(s) this PR fixes:
Vanity Domain Flip: https://github.com/kubernetes/k8s.io/blob/master/k8s.gcr.io/Vanity-Domain-Flip.md
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: