Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nvidia-gpu-device-plugin addon image path #96276

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Update nvidia-gpu-device-plugin addon image path #96276

merged 1 commit into from
Jan 4, 2021

Conversation

ruiwen-zhao
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
As part of the Vanity Domain Flip, the old image registry (k8s.gcr.io) is deprecated. This PR moves the image path to a new registry. Note that the new image is still built from the same commit as the old one, so there is no functionality change.

Which issue(s) this PR fixes:

Vanity Domain Flip: https://github.com/kubernetes/k8s.io/blob/master/k8s.gcr.io/Vanity-Domain-Flip.md

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 5, 2020
@k8s-ci-robot
Copy link
Contributor

@ruiwen-zhao: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Hi @ruiwen-zhao. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 5, 2020
@ruiwen-zhao
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 5, 2020
@rphillips
Copy link
Member

/ok-to-test
/lgtm

/assign @dims

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 5, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2020
@ruiwen-zhao
Copy link
Contributor Author

The error does not seem to be relevant. And there is already effort fixing it: #96274

I1105 20:45:26.960] [sig-auth] ServiceAccounts
I1105 20:45:26.960] test/e2e/auth/framework.go:23
I1105 20:45:26.960]   should guarantee kube-root-ca.crt exist in any namespace [It]
I1105 20:45:26.960]   test/e2e/auth/service_accounts.go:860
I1105 20:45:26.961] 
I1105 20:45:26.961]   Nov  5 20:45:19.981: Unexpected error:
      
I1105 20:45:26.961]       <*errors.errorString | 0xc00027c1f0>: {
I1105 20:45:26.961]           s: "timed out waiting for the condition",
I1105 20:45:26.961]       }
I1105 20:45:26.961]       timed out waiting for the condition
I1105 20:45:26.961]   occurred

@ruiwen-zhao
Copy link
Contributor Author

/retest

@dims
Copy link
Member

dims commented Jan 4, 2021

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, ruiwen-zhao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2021
@BenTheElder
Copy link
Member

As part of the Vanity Domain Flip, the old image registry (k8s.gcr.io) is deprecated. This PR moves the image path to a new registry. Note that the new image is still built from the same commit as the old one, so there is no functionality change.

Huh? gcr.io/google_containers was deprecated, k8s.gcr.io is the defacto Kubernetes OSS release registry. k8s.gcr.io is NOT deprecated

@ruiwen-zhao
Copy link
Contributor Author

As part of the Vanity Domain Flip, the old image registry (k8s.gcr.io) is deprecated. This PR moves the image path to a new registry. Note that the new image is still built from the same commit as the old one, so there is no functionality change.

Huh? gcr.io/google_containers was deprecated, k8s.gcr.io is the defacto Kubernetes OSS release registry. k8s.gcr.io is NOT deprecated

sorry that was a typo. Yeah gcr.io/google_containers was deprecated but k8s.gcr.io was not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants