Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create example component for integrating with component-base #96374

Merged
merged 1 commit into from Jun 7, 2021
Merged

Create example component for integrating with component-base #96374

merged 1 commit into from Jun 7, 2021

Conversation

serathius
Copy link
Contributor

@serathius serathius commented Nov 9, 2020 •
edited

/cc @mtaufen

For logging sanitization we would like to introduce tests that would verity that enabling new flag will impact logs written by component. Idea was to create very simple binary based on k8s.io/component-base, run it and check if results match.

This PR shows example of creating example component and configuring logging options on it. As next step we would automate testing logs written possibly by running it from bazel.

Before moving forward with this example component for logging I would like to discuss this idea with component-base owners if we can expand this idea.
/cc @mtaufen

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Nov 9, 2020
@serathius
Copy link
Contributor Author

/wg component-standard

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. wg/component-standard Categorizes an issue or PR as relevant to WG Component Standard. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 9, 2020
@serathius
Copy link
Contributor Author

/cc @44past4

@fedebongio
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Nov 10, 2020
@serathius
Copy link
Contributor Author

Adding more component base owners to take a look
/cc mtaufen stealthybox luxas stewart-yu dims dixudx rosti

@dims
Copy link
Member

dims commented Nov 14, 2020

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from dims November 14, 2020 01:55
@stewart-yu
Copy link
Contributor

stewart-yu commented Jan 9, 2021 •
edited

where the background about the PR or proposal?

@serathius
Copy link
Contributor Author

This is just a POC of idea that I wanted to get feedback from component-standard working group. Unfortunately didn't get any response. Proposal would be created after we confirm there is interest in this.

Will try to reach out to @mtaufen directly when I have time.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 6, 2021
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 5, 2021
@serathius serathius force-pushed the example branch 2 times, most recently from bacb7be to 8926777 Compare June 5, 2021 16:30
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 5, 2021
@serathius serathius changed the title [WIP] Create example component for integrating with component-base Create example component for integrating with component-base Jun 5, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2021
@serathius
Copy link
Contributor Author

/cc @kubernetes/wg-structured-logging-reviews
/wg structured-logging

@k8s-ci-robot k8s-ci-robot added the wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging. label Jun 5, 2021
@serathius
Copy link
Contributor Author

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 6, 2021
@yangjunmyfm192085
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit fca27ee into kubernetes:master Jun 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 7, 2021
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtaufen mtaufen Awaiting requested review from mtaufen

@44past4 44past4 Awaiting requested review from 44past4

@dixudx dixudx Awaiting requested review from dixudx

@luxas luxas Awaiting requested review from luxas

@rosti rosti Awaiting requested review from rosti

@stealthybox stealthybox Awaiting requested review from stealthybox

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

Assignees

@yangjunmyfm192085 yangjunmyfm192085

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/component-standard Categorizes an issue or PR as relevant to WG Component Standard. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@serathius @k8s-ci-robot @fedebongio @dims @stewart-yu @yangjunmyfm192085