Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiextensions apiserver: update storage version for custom resources #96403

Closed
wants to merge 10 commits into from

Commits on Jan 26, 2021

  1. Configuration menu
    Copy the full SHA
    2aa2965 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ac6a4ea View commit details
    Browse the repository at this point in the history
  3. generated

    roycaihw committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    5ff32e9 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2021

  1. Configuration menu
    Copy the full SHA
    2c902a4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5faab59 View commit details
    Browse the repository at this point in the history
  3. generated

    roycaihw committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    35d9ffc View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. unify processedCh and abortedCh

    When a storage version update is aborted because the CRD was deleted, we
    don't need to reject in-flight CR requests. We can safely allow these
    requests to proceed, because the CRD finalizer guarantees no write
    requests can succeed after a CRD is deleted-- CREATE requests are 405
    NOT ALLOWED, other requests will get 404 NOT FOUND.
    roycaihw committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    8661f73 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3cd443e View commit details
    Browse the repository at this point in the history
  3. make sure the chance for an existing race is low

    In theory, "CRD deletion and CRD finalizer tearing-down CRs" could happen
    in between 1. crdHandler saw CRD terminating=false and 2. crdHandler
    serves CR create request.
    
    This commit makes crdHandler read the latest CRD from the cache (shared
    with CRD finalizer) right before serving the create request, to make
    sure the gap is as narrow as possible, and the chance for the race is
    still low.
    roycaihw committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    6ddc1eb View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2021

  1. Configuration menu
    Copy the full SHA
    100aa3b View commit details
    Browse the repository at this point in the history