Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install pigz for GCE Windows Nodes. #96470

Merged
merged 1 commit into from Dec 11, 2020
Merged

Install pigz for GCE Windows Nodes. #96470

merged 1 commit into from Dec 11, 2020

Conversation

jeremyje
Copy link
Contributor

@jeremyje jeremyje commented Nov 11, 2020 •
edited

What type of PR is this?
/kind feature

What this PR does / why we need it:
Improves Image Pull Performance on GCE Windows nodes on multi-processor VMs.

After benchmarking I see an overall improvement of about 4.46%.

Which issue(s) this PR fixes:

Fixes #96313

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 11, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @jeremyje. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 11, 2020
@jeremyje
Copy link
Contributor Author

/sig windows

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 11, 2020
@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 11, 2020
@jeremyje
Copy link
Contributor Author

CC: @pjh

@pjh
Copy link
Contributor

pjh commented Nov 12, 2020

/ok-to-test
/priority important-soon

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 12, 2020
@pjh
Copy link
Contributor

pjh commented Nov 12, 2020

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 12, 2020
pjh
pjh reviewed Nov 12, 2020
View reviewed changes
cluster/gce/config-default.sh Outdated Show resolved Hide resolved
cluster/gce/util.sh Outdated Show resolved Hide resolved
cluster/gce/windows/k8s-node-setup.psm1 Show resolved Hide resolved
@pjh
Copy link
Contributor

pjh commented Nov 12, 2020

/test pull-kubernetes-e2e-windows-gce

@pjh
Copy link
Contributor

pjh commented Nov 13, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2020
@jeremyje
Copy link
Contributor Author

jeremyje commented Nov 16, 2020 •
edited

Ping @mwielgus @yliaog for approval.

@yliaog
Copy link
Contributor

yliaog commented Dec 2, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2020
@jeremyje
Copy link
Contributor Author

jeremyje commented Dec 2, 2020

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 2, 2020 •
edited

@jeremyje: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-windows-gce 0078f45fd9507fa95b0c5f564729a731c907b3b6 link /test pull-kubernetes-e2e-windows-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yliaog
Copy link
Contributor

yliaog commented Dec 3, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeremyje, pjh, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2020
@pjh
Copy link
Contributor

pjh commented Dec 11, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0e2bf1e into kubernetes:master Dec 11, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Dec 11, 2020
@jeremyje jeremyje deleted the gkewinpigz branch December 11, 2020 23:05
@pjh pjh mentioned this pull request Jan 15, 2021
Merged
@pjh
Copy link
Contributor

pjh commented Jan 15, 2021

A small fix to this change: #98081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjh pjh pjh left review comments

@yliaog yliaog yliaog left review comments

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@pjh pjh

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

Install pigz to GCE Windows Node Image
4 participants
@jeremyje @k8s-ci-robot @pjh @yliaog