Using bigger node for minions for jenkin-e2e tests. #9678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
|
LGTM |
ghost
added
the
lgtm
| @@ -53,6 +54,7 @@ else | |||
| export MASTER_SIZE=${MASTER_SIZE:-"t2.small"} | |||
| else | |||
| export MASTER_SIZE=${MASTER_SIZE:-"g1-small"} | |||
There was a problem hiding this comment.
Change to n1-standard-1 too?
There was a problem hiding this comment.
Totally agree. We should never be running on shared cores for CI e2e tests. It introduces unnecessary timing variability, which makes debugging more difficult.
There was a problem hiding this comment.
Our performance goals are phrased in the context of an n1-standard-4 master (#6454)
|
Done! |
ghost
pushed a commit
that referenced
this pull request
Jun 11, 2015
Using bigger node for minions for jenkin-e2e tests.
ghost
merged commit 
|
GCE e2e build/test failed for commit a1065d1. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc/ @brendandburns @quinton-hoole
This is not a fix for #9312, but it should help us to rule out failure such as:
#9312 (comment)