Export GetIptablesVersion utility in pkg/util/iptables #9679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
ArtfulCoder
added
sig/network
| @@ -343,6 +343,15 @@ func getIptablesVersionString(exec utilexec.Interface) (string, error) { | |||
| return string(bytes), nil | |||
| } | |||
|
|
|||
| //exported utility for use with kube-proxy | |||
| func GetIptablesVersion(exec utilexec.Interface) (int, int, int, error) { | |||
There was a problem hiding this comment.
Can you add a properly formatted godoc comment to this now that it is public?
mikedanese
added
the
lgtm
fabioy
added a commit
that referenced
this pull request
Jun 15, 2015
Export GetIptablesVersion utility in pkg/util/iptables
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For kube-proxy to determine whether to use pure iptables as in #3760
Related WIP PR: #9210