Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionalize (default false) --insecure-registry. #9685

Merged
merged 1 commit into from Jun 13, 2015

Conversation

brendandburns
Copy link
Contributor

@roberthbailey
Copy link
Contributor

LGTM.

@roberthbailey roberthbailey added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2015
@roberthbailey roberthbailey self-assigned this Jun 11, 2015
@k8s-bot
Copy link

k8s-bot commented Jun 11, 2015

GCE e2e build/test failed for commit 1985535174afa60889d47fe1b714b3a2bae6f9c7.

@ixdy
Copy link
Member

ixdy commented Jun 11, 2015

@k8s-bot test this please

@k8s-bot
Copy link

k8s-bot commented Jun 11, 2015

GCE e2e build/test failed for commit 1985535174afa60889d47fe1b714b3a2bae6f9c7.

@brendandburns
Copy link
Contributor Author

The e2e build error is some permission error, but this is failing to turn up clusters in my project, hang on while I figure out why...

@ixdy
Copy link
Member

ixdy commented Jun 11, 2015

We ran out of disk space on the Jenkins master. Apologies for the noise.

@brendandburns
Copy link
Contributor Author

Ok, I validated this in my own cluster, should be good to go from my side.

@k8s-bot
Copy link

k8s-bot commented Jun 11, 2015

GCE e2e build/test failed for commit 675d837.

@ixdy
Copy link
Member

ixdy commented Jun 12, 2015

@k8s-bot test this please

@k8s-bot
Copy link

k8s-bot commented Jun 12, 2015

GCE e2e build/test failed for commit 675d837.

ArtfulCoder added a commit that referenced this pull request Jun 13, 2015
Optionalize (default false) --insecure-registry.
@ArtfulCoder ArtfulCoder merged commit a6bed65 into kubernetes:master Jun 13, 2015
@dchen1107
Copy link
Member

I believe this causes the issue on cluster initialization, I am reverting it.

@ixdy
Copy link
Member

ixdy commented Jun 13, 2015

Interestingly, it looks like the final pre-merge Jenkins run also failed in the same way as #9760. I guess it really is starting to give some useful signal - if only we had listened to it. :)

@brendandburns
Copy link
Contributor Author

Hrmph, sorry about that, I swear it turned up clusters successfully on my machine. I will debug further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants