-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionalize (default false) --insecure-registry. #9685
Conversation
LGTM. |
GCE e2e build/test failed for commit 1985535174afa60889d47fe1b714b3a2bae6f9c7. |
@k8s-bot test this please |
GCE e2e build/test failed for commit 1985535174afa60889d47fe1b714b3a2bae6f9c7. |
The e2e build error is some permission error, but this is failing to turn up clusters in my project, hang on while I figure out why... |
We ran out of disk space on the Jenkins master. Apologies for the noise. |
Ok, I validated this in my own cluster, should be good to go from my side. |
GCE e2e build/test failed for commit 675d837. |
@k8s-bot test this please |
GCE e2e build/test failed for commit 675d837. |
Optionalize (default false) --insecure-registry.
I believe this causes the issue on cluster initialization, I am reverting it. |
Interestingly, it looks like the final pre-merge Jenkins run also failed in the same way as #9760. I guess it really is starting to give some useful signal - if only we had listened to it. :) |
Hrmph, sorry about that, I swear it turned up clusters successfully on my machine. I will debug further. |
@roberthbailey @stephenR
Fixes #7964.