-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added what seems to be the default allowable port range for NodePort to the docs #9697
Added what seems to be the default allowable port range for NodePort to the docs #9697
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
I signed it! |
Thanks! The range is actually supposed to be 30000 - 32767, although I had an off-by-one error originally (as you spotted). I fixed my mistake, so the default should now be 30000-32767. |
I was wondering about that :) Updated. |
LGTM |
@pnovotnak can you squash your commits into one? |
Squashed. |
@pnovotnak this is LGTM but I was unable to look up the CLA on our internal system. I looked up your github username, the email on the commit, and the email on your github profile. Are you sure you signed it? Was it a corporate cla? @googlebot is angry. |
@googlebot check again! |
I just submitted another CLA for my personal email address and made sure my github username was attached. The one submitted via my work address' email is: peter@cyrusbio [dot] com |
CLAs look good, thanks! |
@googlebot is pleased. |
…rt-documentation Added what seems to be the default allowable port range for NodePort to the docs
Fixes #9696