Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added what seems to be the default allowable port range for NodePort to the docs #9697

Merged
merged 1 commit into from
Jun 16, 2015
Merged

Added what seems to be the default allowable port range for NodePort to the docs #9697

merged 1 commit into from
Jun 16, 2015

Conversation

pnovotnak
Copy link

Fixes #9696

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@k8s-bot
Copy link

k8s-bot commented Jun 12, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@pnovotnak
Copy link
Author

I signed it!

@justinsb
Copy link
Member

Thanks! The range is actually supposed to be 30000 - 32767, although I had an off-by-one error originally (as you spotted). I fixed my mistake, so the default should now be 30000-32767.

@pnovotnak
Copy link
Author

I was wondering about that :)

Updated.

@justinsb
Copy link
Member

LGTM

@ArtfulCoder ArtfulCoder added sig/network Categorizes an issue or PR as relevant to SIG Network. team/cluster labels Jun 12, 2015
@mikedanese
Copy link
Member

@pnovotnak can you squash your commits into one?

@pnovotnak
Copy link
Author

Squashed.

@mikedanese
Copy link
Member

@pnovotnak this is LGTM but I was unable to look up the CLA on our internal system. I looked up your github username, the email on the commit, and the email on your github profile. Are you sure you signed it? Was it a corporate cla? @googlebot is angry.

@mikedanese
Copy link
Member

@googlebot check again!

@pnovotnak
Copy link
Author

I just submitted another CLA for my personal email address and made sure my github username was attached.

The one submitted via my work address' email is: peter@cyrusbio [dot] com

@googlebot
Copy link

CLAs look good, thanks!

@mikedanese
Copy link
Member

@googlebot is pleased.

@mikedanese mikedanese added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2015
fabioy added a commit that referenced this pull request Jun 16, 2015
…rt-documentation

Added what seems to be the default allowable port range for NodePort to the docs
@fabioy fabioy merged commit 6ab2aee into kubernetes:master Jun 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants