Add a proxy test #9698
Add a proxy test #9698
Conversation
lavalamp
force-pushed
the
e2eTestFix
branch
2 times, most recently
from
15bf020
to
aae846d
Compare
|
Note this depends on a fix in #9592. |
|
GCE e2e build/test failed for commit 39e7e73a69d90db2b127fb5a5f5108bb1d40686e. |
|
GCE e2e build/test failed for commit 15bf0200f368c7a52ba8aae46b4b1dbb47b4fd70. |
|
GCE e2e build/test failed for commit aae846db4a28bed805e0d2febd9cadade08b7a6e. |
|
GCE e2e build/test failed for commit 8eeb948ee846c6e4f8e519c3770148f96c85662f. |
|
GCE e2e build/test failed for commit 42292bc76f324a08b3098e37595dd7540c17cc6c. |
| @@ -103,3 +103,47 @@ func (f *Framework) WaitForPodRunning(podName string) error { | |||
| func (f *Framework) TestContainerOutput(scenarioName string, pod *api.Pod, expectedOutput []string) { | |||
| testContainerOutputInNamespace(scenarioName, f.Client, pod, expectedOutput, f.Namespace.Name) | |||
| } | |||
|
|
|||
| func (f *Framework) WaitForEndpoints(serviceName string) error { | |||
There was a problem hiding this comment.
Document what this does. The name seems to indicate it waits for all to be ok, but the implementation just waits for one to be ok.
There was a problem hiding this comment.
Will fix. It's confusing because we named a single object "Endpoints"...
|
Small comments. Shippable is a flake, hit it again. |
|
Updated. This won't pass e2e until #9592 is merged. |
|
GCE e2e build/test failed for commit e29245f. |
|
LGTM. #9592 has been merged. Merging this as it's a very useful signal and the change is limited to a single test, and easy to roll back if required. I'll keep an eye on it over the weekend. |
ghost
added
the
lgtm
ghost
merged commit
|
@k8s-bot test this please |
Fixes #9533