Update github.com/miekg/dns to pick up fix for CVE-2019-19794.

[dlorenc]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

I noticed this was out of date using 'snyk test' on the main repository.

More info is available here: https://snyk.io/vuln/SNYK-GOLANG-GITHUBCOMMIEKGDNS-537825

I don't think the codepath in question is used directly here, but I'm not 100% sure.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

@dlorenc: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dlorenc]

This should be ready for review
/assign @dchen1107

[aojea]

/assign @liggitt @dims

[liggitt]

I don't think the codepath in question is used directly here, but I'm not 100% sure.

it is not, the only places this dependency is used is in test/e2e code and in pkg/proxy/winuserspace/proxysocket.go to decode a DNS request.

Ideally we could drop this dependency completely. I'll defer to sig-network and sig-windows to review the update

/sig network windows

[liggitt]

/approve
for dependency mechanics

/hold for network/windows review

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlorenc, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aojea]

Ideally we could drop this dependency completely. I'll defer to sig-network and sig-windows to review the update

I've added the e2e dependency, but it just uses a helper function that can be copied, but it seems that there was some discussion with the winproxy dependency and is not clear to me the conclusion.

#45642

/hold
/assign
let me see if we can remove one dependency

[dims]

@aojea how about we merge and iterate?

[aojea]

@aojea how about we merge and iterate?

yep, the windows dependency doesn't seem to be resolved soon :)
/hod cancel

[aojea]

/hold cancel

[dlorenc]

Thanks! I took a look at the windows dependency and it seems pretty small (one struct, dns.Msg), but that struct pulls in about a dozen other structs and interfaces totaling a few hundred lines of code.

[dims]

/lgtm