Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding a suffix to the devel staging path for server tars on GCS. #9744

Merged
merged 1 commit into from Jun 12, 2015

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Jun 12, 2015

This is needed to allow multiple GCE e2e runs to occur using the same
project on Jenkins.'

cc @quinton-hoole

This is needed to allow multiple GCE e2e runs to occur using the same
project on Jenkins.
@ghost ghost self-assigned this Jun 12, 2015
@ixdy
Copy link
Member Author

ixdy commented Jun 12, 2015

I'd like to see this work on Jenkins before merging. (I've already updated the config to set KUBE_GCS_STAGING_PATH_SUFFIX=-${EXECUTOR_NUMBER})

@ghost ghost added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2015
@ghost
Copy link

ghost commented Jun 12, 2015

LGTM

@k8s-bot
Copy link

k8s-bot commented Jun 12, 2015

GCE e2e build/test failed for commit fcba313.

@ixdy
Copy link
Member Author

ixdy commented Jun 12, 2015

I can't tell if the e2e failure is real or a flake. The cluster came up without issue, at least.

@ixdy
Copy link
Member Author

ixdy commented Jun 12, 2015

@k8s-bot test this please

@ixdy
Copy link
Member Author

ixdy commented Jun 12, 2015

@ArtfulCoder the PR-per e2e runs may occasionally fail until this fix is merged.

ArtfulCoder added a commit that referenced this pull request Jun 12, 2015
Allow adding a suffix to the devel staging path for server tars on GCS.
@ArtfulCoder ArtfulCoder merged commit 42be6db into kubernetes:master Jun 12, 2015
@k8s-bot
Copy link

k8s-bot commented Jun 12, 2015

GCE e2e build/test passed for commit fcba313.

@ixdy ixdy unassigned ghost Aug 12, 2015
@ixdy ixdy deleted the gcs-staging-path branch August 21, 2015 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants