add k8petstore-nodeport.sh for examples/k8petstore #9748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 12, 2015 15:16
Add examples/k8petstore/k8petstore-loadbalancer.sh
|
GCE e2e build/test passed for commit 79963be. |
|
Hi ... whats the error? It looks simply like Redis isn't up yet. looks like maybe the original comment was deleted ? |
|
Hi @jayunit100, I found the cause of the error. Sorry for the false alarm. I will update the script again. I'm making it work for local cluster now. |
|
okcool. we can improve the error reporting in a later issue. |
|
Hi @jayunit100, now the script also works if k8s is running on a local cluster. PTAL. Is there other situations that I missed? |
|
GCE e2e build/test failed for commit 4c3a15f. |
|
LGTM thanks ! Now we can hopefully use this as a migration example |
eparis
added
the
lgtm
|
@k8s-bot ok to test |
|
GCE e2e build/test failed for commit 4c3a15f. |
|
@k8s-bot ok to test |
|
GCE e2e build/test passed for commit 4c3a15f. |
saad-ali
added a commit
that referenced
this pull request
Jun 17, 2015
add k8petstore-nodeport.sh for examples/k8petstore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #9586. The last commit is the diff.
k8petstore-nodeport.sh is tested on GCE. It needs to be modified if it's not run on a cloud platform.
@jayunit100 @eparis , could you take a look? Thanks.