Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set numberOfWorkers for netpol suite to the ideal value (3) that is n… #97702

Merged
merged 1 commit into from Jan 7, 2021
Merged

set numberOfWorkers for netpol suite to the ideal value (3) that is n… #97702

merged 1 commit into from Jan 7, 2021

Conversation

jayunit100
Copy link
Member

@jayunit100 jayunit100 commented Jan 5, 2021 •
edited

Fixes #97744

Implements the learnings from #97690 to be more polite to the other ginkgo sig-network tests...

image

the inflection point for test speed here is clearly 3 threads, at which point concurrency gives us diminishing returns.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 5, 2021
@jayunit100
Copy link
Member Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 5, 2021
@jayunit100
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 5, 2021
@k8s-ci-robot k8s-ci-robot added area/test sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 5, 2021
@jayunit100 jayunit100 mentioned this pull request Jan 5, 2021
Closed
@aojea
Copy link
Member

aojea commented Jan 5, 2021

/retest
/lgtm
/sig network
/kind flake

@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 5, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2021
@mattfenwick
Copy link
Contributor

/approve

@mattfenwick
Copy link
Contributor

Whoops, looks like I don't have permissions to approve!

@jayunit100 jayunit100 mentioned this pull request Jan 6, 2021
Closed
@aojea
Copy link
Member

aojea commented Jan 6, 2021

/assign @andrewsykim
Andrew can you PTAL?

@aojea
Copy link
Member

aojea commented Jan 6, 2021

@jayunit100 can you add to the description

Fixes #97744

so it will close the issue automatically after merge?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jayunit100, mattfenwick, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2021
@aojea
Copy link
Member

aojea commented Jan 7, 2021

@jayunit100 ping, it needs rebase

@jayunit100
Copy link
Member Author

ah fixing now , has

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 7, 2021
@rikatz
Copy link
Contributor

rikatz commented Jan 7, 2021

/lgtm

And let's get this merged :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2021
@rikatz
Copy link
Contributor

rikatz commented Jan 7, 2021

/test pull-kubernetes-e2e-ubuntu-gce-network-policies

@aojea
Copy link
Member

aojea commented Jan 7, 2021 •
edited

/test pull-kubernetes-bazel-test

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 7, 2021 •
edited

@jayunit100: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-ubuntu-gce-network-policies ba0a870 link /test pull-kubernetes-e2e-ubuntu-gce-network-policies

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aojea
Copy link
Member

aojea commented Jan 7, 2021 •
edited

Kubernetes e2e suite: [sig-api-machinery] ResourceQuota should create a ResourceQuota and capture the life of a pod. [Conformance] expand_more49s | Kubernetes e2e suite: [sig-api-machinery] ResourceQuota should create a ResourceQuota and capture the life of a pod. [Conformance] expand_more | 49s
Kubernetes e2e suite: [sig-network] NetworkPolicy [LinuxOnly] NetworkPolicy between server and client should enforce policy to allow traffic only from a different namespace, based on NamespaceSelector [Feature:NetworkPolicy] expand_more | 39s

seems that the old network policy tests give up too fast
/retest

@k8s-ci-robot k8s-ci-robot merged commit 611aff9 into kubernetes:master Jan 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacoxu pacoxu pacoxu approved these changes

@bowei bowei Awaiting requested review from bowei

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@aojea aojea

@rikatz rikatz

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

pr:pull-kubernetes-e2e-ubuntu-gce-network-policies flaked 4 times in the past week
7 participants
@jayunit100 @aojea @mattfenwick @k8s-ci-robot @rikatz @pacoxu @andrewsykim