New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test images: Fixes echoserver image for Windows #98189
test images: Fixes echoserver image for Windows #98189
Conversation
/assign @dims |
@@ -19,21 +19,24 @@ ARG REGISTRY | |||
FROM --platform=linux/amd64 alpine:3.6 as prep | |||
|
|||
ADD https://openresty.org/download/openresty-1.13.6.2-win64.zip /openresty-win64.zip | |||
ADD http://wiki.overbyte.eu/arch/openssl-1.1.1i-win64.zip /openssl.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks looks soooo shady!! :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got this URL from here: https://wiki.openssl.org/index.php/Binaries
So, it should be fine, IMO.
|
||
ENV PATH="C:\openresty\;C:\bin\;C:\curl\;C:\Windows\system32;C:\Windows;C:\Program Files\PowerShell;" | ||
ADD ["https://raw.githubusercontent.com/openssl/openssl/OpenSSL_1_1_1-stable/apps/openssl.cnf", "/Program Files/Common Files/SSL/openssl.cnf"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this available off of a tag? (is this likely to change in master?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's taken from the https://github.com/openssl/openssl/tree/OpenSSL_1_1_1-stable
branch, but we can probably use the https://github.com/openssl/openssl/tree/OpenSSL_1_1_1i
tag instead.
fc38015
to
4a151fe
Compare
The Windows echoserver image no longer relies on a helper image.
4a151fe
to
483ed6a
Compare
/retest |
/triage accepted |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: claudiubelu, dims The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/sig windows
/sig testing
/priority important-soon
What this PR does / why we need it:
The Windows echoserver image no longer relies on a helper image.
This addresses the current echoserver image builder postsubmit job which is currently failing [1].
[1] https://testgrid.k8s.io/sig-testing-images#post-kubernetes-push-e2e-echoserver-test-images
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: