Automated cherry pick of #97700: OWNERS: Update SIG Release aliases #98371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're currently only using this for changelog approvals and those should really be handled by relnotes + RelEng. Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: hasheddan <georgedanielmangum@gmail.com> Co-authored-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: hasheddan <georgedanielmangum@gmail.com> Co-authored-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
k8s-ci-robot
added
do-not-merge/cherry-pick-not-approved
|
@hasheddan: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-triage
|
/kind cleanup |
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/release-eng
|
/assign @liggitt |
|
do we want to pick #98701 instead so that sig-release can manage this themselves going forward? |
Given we're pulling the relnotes team into review, the changes to reviewers will happen a little more frequently, which means we'll have the same issue of needing a top-level approver to do updates that we were trying to avoid by creating the subdirectory in the first place. Signed-off-by: Stephen Augustus <foo@auggie.dev> (cherry picked from commit 5639cd9)
Dan and Sascha are senior Release Managers, SIG Release leadership, and have already been giving thoughtful reviews of the content in this directory. Adding them as reviewers to spread the load of SIG Release eyes on content. Signed-off-by: Stephen Augustus <foo@auggie.dev> (cherry picked from commit 1a43c65)
|
/approve will leave lgtm to sig-release reviewer |
k8s-ci-robot
added
the
approved
|
/assign @justaugustus |
justaugustus
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hasheddan, justaugustus, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
justaugustus
added
the
cherry-pick-approved
k8s-ci-robot
removed
the
do-not-merge/cherry-pick-not-approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #97700 on release-1.18.
#97700: OWNERS(sig-release): Remove SIG Release approvers alias
For details on the cherry pick process, see the cherry pick requests page.