New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Emptydir and security context #9844
Conversation
GCE e2e build/test failed for commit 05f4a962597e6748fc8ad365eb9fc38492d91c32. |
@@ -139,6 +147,7 @@ const ( | |||
// These do not persist beyond the lifetime of a pod. | |||
type emptyDir struct { | |||
podUID types.UID | |||
pod *api.Pod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you ned PodUID then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't, and I've taken it out of the downstream patch for this. I've been pretty much embroiled in prep for the OpenShift launch but once the dust settles I will update this PR.
GCE e2e build/test failed for commit 05f4a962597e6748fc8ad365eb9fc38492d91c32. |
7c273c6
to
1b87a94
Compare
GCE e2e build/test failed for commit 1b87a94f70240e6cfdb4d958f2215125e7dc6301. |
GCE e2e build/test failed for commit 7c273c67f27defb46a9287e6896be1542345da70. |
GCE e2e build/test failed for commit 6393987072d834d103e3d86511cb7887df69171f. |
GCE e2e build/test failed for commit 105259ee11007b88e6080256f2e77f1a861394ad. |
I also expect this to fail until the |
GCE e2e build/test passed for commit d9891c62415c1e524bf6202a1c8ec8113c51a026. |
Conflicts: pkg/volume/empty_dir/empty_dir.go
@thockin This is the next one I'm going to bug you about -- I'm going to refactor this code but I'm carrying a patch for this in OpenShift and so it makes sense for me to begin refactoring from this state. |
GCE e2e build/test passed for commit a9e8d88. |
@pmorie - this one could use a little love too... likely goes with the other work? |
Labelling this PR as size/L |
Thx @pmorie - I'll watch over there instead. ;) |
Superceded by #14192, closing out. |
WIP for #7925
Very rough, mostly to track the downstream work I'm doing in openshift