Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Emptydir and security context #9844

Closed
wants to merge 1 commit into from

Conversation

pmorie
Copy link
Member

@pmorie pmorie commented Jun 16, 2015

WIP for #7925

Very rough, mostly to track the downstream work I'm doing in openshift

@pmorie pmorie changed the title WIP: Emptydir selinux WIP: Emptydir and security context Jun 16, 2015
@k8s-bot
Copy link

k8s-bot commented Jun 16, 2015

GCE e2e build/test failed for commit 05f4a962597e6748fc8ad365eb9fc38492d91c32.

@@ -139,6 +147,7 @@ const (
// These do not persist beyond the lifetime of a pod.
type emptyDir struct {
podUID types.UID
pod *api.Pod
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you ned PodUID then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't, and I've taken it out of the downstream patch for this. I've been pretty much embroiled in prep for the OpenShift launch but once the dust settles I will update this PR.

@k8s-bot
Copy link

k8s-bot commented Jul 20, 2015

GCE e2e build/test failed for commit 05f4a962597e6748fc8ad365eb9fc38492d91c32.

@pmorie pmorie force-pushed the emptydir-selinux branch 2 times, most recently from 7c273c6 to 1b87a94 Compare July 27, 2015 02:50
@k8s-bot
Copy link

k8s-bot commented Jul 27, 2015

GCE e2e build/test failed for commit 1b87a94f70240e6cfdb4d958f2215125e7dc6301.

@k8s-bot
Copy link

k8s-bot commented Jul 27, 2015

GCE e2e build/test failed for commit 7c273c67f27defb46a9287e6896be1542345da70.

@k8s-bot
Copy link

k8s-bot commented Jul 28, 2015

GCE e2e build/test failed for commit 6393987072d834d103e3d86511cb7887df69171f.

@k8s-bot
Copy link

k8s-bot commented Jul 29, 2015

GCE e2e build/test failed for commit 105259ee11007b88e6080256f2e77f1a861394ad.

@pmorie
Copy link
Member Author

pmorie commented Jul 29, 2015

I also expect this to fail until the mounttest-user image is pushed to gcr.io

@k8s-bot
Copy link

k8s-bot commented Jul 29, 2015

GCE e2e build/test passed for commit d9891c62415c1e524bf6202a1c8ec8113c51a026.

Conflicts:
	pkg/volume/empty_dir/empty_dir.go
@pmorie
Copy link
Member Author

pmorie commented Jul 30, 2015

@thockin This is the next one I'm going to bug you about -- I'm going to refactor this code but I'm carrying a patch for this in OpenShift and so it makes sense for me to begin refactoring from this state.

@k8s-bot
Copy link

k8s-bot commented Jul 30, 2015

GCE e2e build/test passed for commit a9e8d88.

@ghost ghost mentioned this pull request Aug 25, 2015
@mrry550
Copy link

mrry550 commented Aug 26, 2015

@pmorie - this one could use a little love too... likely goes with the other work?

@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 27, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/L

@pmorie
Copy link
Member Author

pmorie commented Sep 8, 2015

@mrry550 This PR is likely not going in. #12944 supercedes it.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2015
@mrry550
Copy link

mrry550 commented Sep 10, 2015

Thx @pmorie - I'll watch over there instead. ;)

@pmorie
Copy link
Member Author

pmorie commented Oct 1, 2015

Superceded by #14192, closing out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants