Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for existing GCE resources in kube-up #9859

Merged
merged 2 commits into from Jun 18, 2015

Conversation

mwielgus
Copy link
Contributor

Fix for #8285.
With this PR kube-up.sh will inform the user if he has some conflicting GCE resources (pds, templates, instances, etc) that should be removed. The check is made if:

  • the user runs kube-up.sh in a terminal (stdout is bound to a terminal). In this case, if any resources are found, he will be asked for confirmation whether he wants to run kube-down or not.
  • KUBE_UP_AUTOMATIC_CLEANUP is set to true. In this case kube-down is run automatically if needed.

@k8s-bot
Copy link

k8s-bot commented Jun 16, 2015

GCE e2e build/test passed for commit e13a3545bc97502dae17a7034e63e2eb3991bccb.

@@ -584,6 +584,26 @@ function kube-up {
find-release-tars
upload-server-tars

local running_in_terminal=false
if [ -t 1 ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment when this may give false negative.

@k8s-bot
Copy link

k8s-bot commented Jun 17, 2015

GCE e2e build/test passed for commit cbc55f29bf4f95b464cce3fbda714925ec7f3727.

@gmarek
Copy link
Contributor

gmarek commented Jun 17, 2015

LGTM. @zmerlynn are you OK with the current version?

@k8s-bot
Copy link

k8s-bot commented Jun 17, 2015

GCE e2e build/test passed for commit 66078be3bbc710e38001d4c7052a268ef99786e9.

@k8s-bot
Copy link

k8s-bot commented Jun 17, 2015

GCE e2e build/test passed for commit 29a0c4bce90643270b49d45a4e05a2fd0b821d7b.

@k8s-bot
Copy link

k8s-bot commented Jun 17, 2015

GCE e2e build/test passed for commit b33b881.

@zmerlynn
Copy link
Member

Have you tested this cross-project? I think the right way is to spin up a cluster in your main project and validate that none of the resources in that cluster block the cross-project creation.

@mwielgus
Copy link
Contributor Author

Yes, it seems that with the added --project parameter everything works as intended.

./kube-up.sh
Starting cluster using provider: gce
... calling verify-prereqs

All components are up to date.

All components are up to date.

All components are up to date.
... calling kube-up
Project: my-other-project
Zone: us-central1-b
+++ Staging server tars to Google Storage: gs://kubernetes-staging-f1a4433947/devel
Looking for already existing resources
Starting master and configuring firewalls

No resources found.

@zmerlynn
Copy link
Member

The current version LGTM.
On Jun 18, 2015 2:37 AM, "Marcin Wielgus" notifications@github.com wrote:

Yes, it seems that with the added --project parameter everything works as
intended.

./kube-up.sh
Starting cluster using provider: gce
... calling verify-prereqs

All components are up to date.

All components are up to date.

All components are up to date.
... calling kube-up
Project: my-other-project
Zone: us-central1-b
+++ Staging server tars to Google Storage: gs://kubernetes-staging-f1a4433947/devel
Looking for already existing resources
Starting master and configuring firewalls

No resources found.


Reply to this email directly or view it on GitHub
#9859 (comment)
.

@zmerlynn zmerlynn added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2015
@satnam6502 satnam6502 added this to the v1.0 milestone Jun 18, 2015
satnam6502 added a commit that referenced this pull request Jun 18, 2015
Check for existing GCE resources in kube-up
@satnam6502 satnam6502 merged commit 34fb2a9 into kubernetes:master Jun 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants