-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for existing GCE resources in kube-up #9859
Conversation
GCE e2e build/test passed for commit e13a3545bc97502dae17a7034e63e2eb3991bccb. |
@@ -584,6 +584,26 @@ function kube-up { | |||
find-release-tars | |||
upload-server-tars | |||
|
|||
local running_in_terminal=false | |||
if [ -t 1 ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment when this may give false negative.
e13a354
to
cbc55f2
Compare
GCE e2e build/test passed for commit cbc55f29bf4f95b464cce3fbda714925ec7f3727. |
66078be
to
29a0c4b
Compare
LGTM. @zmerlynn are you OK with the current version? |
29a0c4b
to
b33b881
Compare
GCE e2e build/test passed for commit 66078be3bbc710e38001d4c7052a268ef99786e9. |
GCE e2e build/test passed for commit 29a0c4bce90643270b49d45a4e05a2fd0b821d7b. |
GCE e2e build/test passed for commit b33b881. |
Have you tested this cross-project? I think the right way is to spin up a cluster in your main project and validate that none of the resources in that cluster block the cross-project creation. |
Yes, it seems that with the added --project parameter everything works as intended.
No resources found. |
The current version LGTM.
|
Check for existing GCE resources in kube-up
Fix for #8285.
With this PR kube-up.sh will inform the user if he has some conflicting GCE resources (pds, templates, instances, etc) that should be removed. The check is made if: