Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch some more images to gcr for reliability #9887

Merged
merged 2 commits into from
Jun 17, 2015

Conversation

brendandburns
Copy link
Contributor

@ghost ghost self-assigned this Jun 16, 2015
@ghost
Copy link

ghost commented Jun 16, 2015

LGTM. We probably want some hierarchy under gcr.io/google_containers (e.g. to separate the custom Kubernetes-built ones from the generic ones like busybox). I assume that all of the images in this PR have been uploaded to gcr.io?

@ghost ghost added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2015
@ghost
Copy link

ghost commented Jun 16, 2015

Oh, and are all of their dependencies in gcr.io also?

@k8s-bot
Copy link

k8s-bot commented Jun 16, 2015

GCE e2e build/test passed for commit c3f4b3f.

@thockin
Copy link
Member

thockin commented Jun 16, 2015

Other than the ones we build from code, who is keeping this nginx (for example) up to date?

@ghost
Copy link

ghost commented Jun 16, 2015

Agreed. I discussed this with @brendandburns offline. Seems we
could/should fix that problem as a separate issue. Pretty sure it exists
independently of this PR.

On Tue, Jun 16, 2015 at 2:06 PM, Tim Hockin notifications@github.com
wrote:

Other than the ones we build from code, who is keeping this nginx (for
example) up to date?


Reply to this email directly or view it on GitHub
#9887 (comment)
.

saad-ali added a commit that referenced this pull request Jun 17, 2015
switch some more images to gcr for reliability
@saad-ali saad-ali merged commit 1063159 into kubernetes:master Jun 17, 2015
@ghost
Copy link

ghost commented Jun 19, 2015

It looks like getContainerOutputInNamespace() failed to get the logs from the container (hence empty string):

Expected
:
to contain substring
: mount type of "/test-volume": tmpfs

I doubt whether that has anything to do with this PR.

@ghost
Copy link

ghost commented Jun 19, 2015

Closes #8849

@brendandburns brendandburns unassigned ghost Aug 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants