Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use golangci-lint to find unused/dead code (Experimental!) #99120

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions hack/make-rules/verify.sh
Expand Up @@ -35,6 +35,7 @@ EXCLUDED_PATTERNS=(
"verify-linkcheck.sh" # runs in separate Jenkins job once per day due to high network usage
"verify-*-dockerized.sh" # Don't run any scripts that intended to be run dockerized
"verify-govet-levee.sh" # Do not run levee analysis by default while KEP-1933 implementation is in alpha.
"verify-golangci-lint.sh" # Experimental - intended to be run by hand periodically
)

# Exclude generated-files-remake in certain cases, if they're running in a separate job.
Expand Down
3 changes: 2 additions & 1 deletion hack/tools/go.mod
Expand Up @@ -7,9 +7,10 @@ require (
github.com/bazelbuild/buildtools v0.0.0-20200228172928-c9d9e342afdb
github.com/cespare/prettybench v0.0.0-20150116022406-03b8cfe5406c
github.com/client9/misspell v0.3.4
github.com/golangci/golangci-lint v1.36.0
github.com/google/go-flow-levee v0.1.4-0.20201102181719-72c65d71b1d3
gotest.tools v2.2.0+incompatible
gotest.tools/gotestsum v0.3.5
honnef.co/go/tools v0.0.1-2020.1.4
honnef.co/go/tools v0.0.1-2020.1.6
k8s.io/repo-infra v0.1.3
)