AWS: Run minions in Auto Scaling Group #9921
Conversation
|
GCE e2e build/test passed for commit 6b281d5aa3f15dbb24643c374c794b2c5026ec54. |
|
Should access to Auto Scaling be added to the IAM policy for either the master or minions? I know there aren't currently any calls to auto scaling commands from kubernetes, but users might run services in their cluster that would expect to be able to scale the ASG? |
|
Ready to review? Push new version? |
|
Reassign to people who have more context on the issue. |
|
Thank you @yujuhong |
justinsb
changed the title
|
@iterion Happy to rethink, but my thought was to keep the permissions minimal until we need more permissions. It's fairly easy for people to change the permission if they want to do more, so until we actually need the permission I don't think we should enable it. @satnam6502 / @cjcullen : No blockers, so should be OK to merge. This PR only affects AWS files as well :-) |
|
GCE e2e build/test passed for commit 7faa4665059ec3edb17c63f5480a5899f7ea9b71. |
|
@justinsb Fair enough, agree it's probably best to keep permissions to a minimum. Excited to see this merged, awesome work on getting this into v1! |
This uses the dynamic CIDR work, and we set source-dest-check to false when we configure the route (which kind-of makes sense)
|
Rebased to get shippable to run (it was still 'in progress' after 12+ hours. |
|
GCE e2e build/test passed for commit 2a5ed2f. |
AWS: Run minions in Auto Scaling Group
Run the minions in an auto-scaling group, to support resizing. Should only affect AWS.
Depends on #9720 (first two commits are 9720)