check IsNotExist error when validating mountpoint #9957
Conversation
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
| @@ -101,7 +101,7 @@ func (util *RBDUtil) AttachDisk(rbd rbd) error { | |||
| // mount it | |||
| globalPDPath := rbd.manager.MakeGlobalPDName(rbd) | |||
| mountpoint, err := rbd.mounter.IsMountPoint(globalPDPath) | |||
| if err != nil { | |||
| if err != nil && !os.IsNotExist(err) { | |||
There was a problem hiding this comment.
I would add a note saying that the mountpoint not existing is a contingency.
Do you want this method to continue running if there's already a mountpoint for this volume?
There was a problem hiding this comment.
yes, if directory is not there, that indicates it is the first time to create then mountpoint. the method should continue to run. the mountpoint is later created.
There was a problem hiding this comment.
K, then I would add a comment there to that effect.
Signed-off-by: Huamin Chen <hchen@redhat.com>
pmorie
added
the
lgtm
|
v1.0 triage needed: Marked the associated issue #9952 as v1.0-candidate |
|
@k8s-bot ok to test |
|
GCE e2e build/test passed for commit 0280dac. |
check IsNotExist error when validating mountpoint
This fixes #9952