-
Notifications
You must be signed in to change notification settings - Fork 39k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server-Side Apply status wiping #99661
Conversation
Hi @kevindelgado. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @liggitt We need to fix one broken test case in status_test, but wanted to get your eyes on this in the meantime @liggitt to begin reviewing this approach to status wiping. The first commit is from @kwiesmueller work from back in July #92809 cc @apelisse |
5e31adb
to
427e771
Compare
/ok-to-test |
513f9ce
to
74dd21a
Compare
/test pull-kubernetes-e2e-kind |
/test pull-kubernetes-integration |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kevindelgado, lavalamp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Does this need to have a 1.21 milestone label in order to land in the release @apelisse? |
I don't think it does, but it wouldn't hurt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, awesome work to both Kevin :-)
/lgtm
3daedd4
to
d95b7a7
Compare
d95b7a7
to
5664d45
Compare
/milestone v1.21 |
5664d45
to
959cd87
Compare
/lgtm |
Adds and implements ResetFieldsProvder interface in order to ensure that the fieldmanager no longer owns fields that get reset before the object is persisted. Co-authored-by: Kevin Wiesmueller <kwiesmul@redhat.com> Co-authored-by: Kevin Delgado <kevindelgado@google.com>
959cd87
to
a1fac8c
Compare
/lgtm |
Thanks for finishing the job! |
I manually removed the "needs-rebase" label, I'm not sure why the bot didn't. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Implements kubernetes/enhancements#1123
Adds the ResetFieldsProvider interface and implements it for all strategies.
Which issue(s) this PR fixes:
Fixes #75564
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: