Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error of setting negative value for containerLogMaxSize #99680

Merged
merged 1 commit into from
May 24, 2021
Merged

fix error of setting negative value for containerLogMaxSize #99680

merged 1 commit into from
May 24, 2021

Conversation

CaoDonghui123
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #99650

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 3, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @CaoDonghui123. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 3, 2021
@wangyysde
Copy link
Member

I have verified the #99650. The kubelet will started normally when the negative value quoted by double quotation.

@ehashman ehashman added this to Triage in SIG Node PR Triage Mar 4, 2021
@CaoDonghui123
Copy link
Contributor Author

ping @ehashman @andrewsykim

@CaoDonghui123
Copy link
Contributor Author

ping @wzshiming

@wzshiming
Copy link
Member

@CaoDonghui123 We are in code-freeze for 1.21

@wzshiming
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 30, 2021
@ehashman
Copy link
Member

ehashman commented Apr 7, 2021

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 7, 2021
@ehashman ehashman moved this from Triage to Needs Reviewer in SIG Node PR Triage Apr 7, 2021
@ehashman ehashman moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Apr 29, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2021
@CaoDonghui123
Copy link
Contributor Author

/assign @sjenning

@finnickkim
Copy link

@CaoDonghui123
Copy link
Contributor Author

ping @mrunalp @klueska

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2021
@CaoDonghui123
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind-ipv6
/test pull-kubernetes-e2e-gce-ubuntu-containerd

@CaoDonghui123
Copy link
Contributor Author

/retest

@ehashman ehashman moved this from Needs Approver to Needs Reviewer in SIG Node PR Triage May 19, 2021
ehashman
ehashman reviewed May 24, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2021
@ehashman ehashman moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage May 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CaoDonghui123, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2021
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage May 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit 88c0e89 into kubernetes:master May 24, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 24, 2021
@CaoDonghui123 CaoDonghui123 deleted the fixissues4 branch May 25, 2021 01:32
This was referenced May 28, 2021
Merged
Merged
@CaoDonghui123 CaoDonghui123 mentioned this pull request Jun 7, 2021
Merged
k8s-ci-robot added a commit that referenced this pull request Jul 10, 2021
@k8s-ci-robot
Merge pull request #102390 from CaoDonghui123/automated-cherry-pick-o…
449b931 
…f-#99680-upstream-release-1.20

Automated cherry pick of #99680: fix error of setting  negative value for containerLogMaxSize
k8s-ci-robot added a commit that referenced this pull request Jul 10, 2021
@k8s-ci-robot
Merge pull request #102389 from CaoDonghui123/automated-cherry-pick-o…
2999dfa 
…f-#99680-upstream-release-1.21

Automated cherry pick of #99680: fix error of setting  negative value for containerLogMaxSize
k8s-ci-robot added a commit that referenced this pull request Oct 14, 2021
@k8s-ci-robot
Merge pull request #102658 from CaoDonghui123/automated-cherry-pick-o…
b71bde1 
…f-#99680-upstream-release-1.19

Automated cherry pick of #99680: fix error of setting negative value for containerLogMaxSize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman left review comments

@wzshiming wzshiming wzshiming requested changes

@mrunalp mrunalp mrunalp approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

Assignees

@sjenning sjenning

@ehashman ehashman

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

kubelet: setting a negative value in containerLogMaxSize raises an error
10 participants
@CaoDonghui123 @k8s-ci-robot @wangyysde @wzshiming @ehashman @umohnani8 @finnickkim @mrunalp @sjenning @SergeyKanzhelev