Add a bit of extra logging to the dns test when it encounters errors. #9977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
ixdy
added
the
lgtm
| Do().Raw() | ||
| if err != nil { | ||
| Do().Raw(); err != nil { | ||
| Logf("Unable to read %s from pod %s: %v", fileName, pod.Name, err) |
There was a problem hiding this comment.
oh, I guess that's not necessary. OK.
There was a problem hiding this comment.
Logf already adds a new line (see https://github.com/GoogleCloudPlatform/kubernetes/blob/master/test/e2e/util.go#L177).
ixdy
added
lgtm
|
Shippable failure seems like a flake, but I don't see a button in their UI to kick the build and make it re-run. Did they remove that recently? |
|
GCE e2e build/test passed for commit cb7bd71. |
saad-ali
added a commit
that referenced
this pull request
Jun 17, 2015
Add a bit of extra logging to the dns test when it encounters errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.