Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup the remaining multi-owned sig-node tests #99853

Merged
merged 1 commit into from Mar 9, 2021
Merged

Cleanup the remaining multi-owned sig-node tests #99853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions test/conformance/testdata/conformance.yaml
View file
Open in desktop
Expand Up @@ -2038,36 +2038,36 @@
file: test/e2e/common/node/expansion.go
- testname: VolumeSubpathEnvExpansion, subpath expansion
codename: '[sig-node] Variable Expansion should allow substituting values in a volume
subpath [sig-storage] [Conformance]'
subpath [Conformance]'
description: Make sure a container's subpath can be set using an expansion of environment
variables.
release: v1.19
file: test/e2e/common/node/expansion.go
- testname: VolumeSubpathEnvExpansion, subpath with absolute path
codename: '[sig-node] Variable Expansion should fail substituting values in a volume
subpath with absolute path [sig-storage][Slow] [Conformance]'
subpath with absolute path [Slow] [Conformance]'
description: Make sure a container's subpath can not be set using an expansion of
environment variables when absolute path is supplied.
release: v1.19
file: test/e2e/common/node/expansion.go
- testname: VolumeSubpathEnvExpansion, subpath with backticks
codename: '[sig-node] Variable Expansion should fail substituting values in a volume
subpath with backticks [sig-storage][Slow] [Conformance]'
subpath with backticks [Slow] [Conformance]'
description: Make sure a container's subpath can not be set using an expansion of
environment variables when backticks are supplied.
release: v1.19
file: test/e2e/common/node/expansion.go
- testname: VolumeSubpathEnvExpansion, subpath test writes
codename: '[sig-node] Variable Expansion should succeed in writing subpaths in container
[sig-storage][Slow] [Conformance]'
[Slow] [Conformance]'
description: "Verify that a subpath expansion can be used to write files into subpaths.
1.\tvalid subpathexpr starts a container running 2.\ttest for valid subpath writes
3.\tsuccessful expansion of the subpathexpr isn't required for volume cleanup"
release: v1.19
file: test/e2e/common/node/expansion.go
- testname: VolumeSubpathEnvExpansion, subpath ready from failed state
codename: '[sig-node] Variable Expansion should verify that a failing subpath expansion
can be modified during the lifecycle of a container [sig-storage][Slow] [Conformance]'
can be modified during the lifecycle of a container [Slow] [Conformance]'
description: Verify that a failing subpath expansion can be modified during the
lifecycle of a container.
release: v1.19
Expand Down
10 changes: 5 additions & 5 deletions test/e2e/common/node/expansion.go
View file
Open in desktop
Expand Up @@ -106,7 +106,7 @@ var _ = SIGDescribe("Variable Expansion", func() {
Testname: VolumeSubpathEnvExpansion, subpath expansion
Description: Make sure a container's subpath can be set using an expansion of environment variables.
*/
framework.ConformanceIt("should allow substituting values in a volume subpath [sig-storage]", func() {
framework.ConformanceIt("should allow substituting values in a volume subpath", func() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're trying to ensure that each test has exactly one owning SIG.

If any of the tests shouldn't be owned by sig-node (and instead owned by sig-storage) - please let me know.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @msau42 @saad-ali

envVars := []v1.EnvVar{
{
Name: "POD_NAME",
Expand Down Expand Up @@ -146,7 +146,7 @@ var _ = SIGDescribe("Variable Expansion", func() {
Testname: VolumeSubpathEnvExpansion, subpath with backticks
Description: Make sure a container's subpath can not be set using an expansion of environment variables when backticks are supplied.
*/
framework.ConformanceIt("should fail substituting values in a volume subpath with backticks [sig-storage][Slow]", func() {
framework.ConformanceIt("should fail substituting values in a volume subpath with backticks [Slow]", func() {

envVars := []v1.EnvVar{
{
Expand Down Expand Up @@ -180,7 +180,7 @@ var _ = SIGDescribe("Variable Expansion", func() {
Testname: VolumeSubpathEnvExpansion, subpath with absolute path
Description: Make sure a container's subpath can not be set using an expansion of environment variables when absolute path is supplied.
*/
framework.ConformanceIt("should fail substituting values in a volume subpath with absolute path [sig-storage][Slow]", func() {
framework.ConformanceIt("should fail substituting values in a volume subpath with absolute path [Slow]", func() {
absolutePath := "/tmp"
if framework.NodeOSDistroIs("windows") {
// Windows does not typically have a C:\tmp folder.
Expand Down Expand Up @@ -219,7 +219,7 @@ var _ = SIGDescribe("Variable Expansion", func() {
Testname: VolumeSubpathEnvExpansion, subpath ready from failed state
Description: Verify that a failing subpath expansion can be modified during the lifecycle of a container.
*/
framework.ConformanceIt("should verify that a failing subpath expansion can be modified during the lifecycle of a container [sig-storage][Slow]", func() {
framework.ConformanceIt("should verify that a failing subpath expansion can be modified during the lifecycle of a container [Slow]", func() {

envVars := []v1.EnvVar{
{
Expand Down Expand Up @@ -288,7 +288,7 @@ var _ = SIGDescribe("Variable Expansion", func() {
3. successful expansion of the subpathexpr isn't required for volume cleanup

*/
framework.ConformanceIt("should succeed in writing subpaths in container [sig-storage][Slow]", func() {
framework.ConformanceIt("should succeed in writing subpaths in container [Slow]", func() {

envVars := []v1.EnvVar{
{
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/node/kubelet.go
View file
Open in desktop
Expand Up @@ -384,7 +384,7 @@ var _ = SIGDescribe("kubelet", func() {
})

// Test host cleanup when disrupting the volume environment.
ginkgo.Describe("host cleanup with volume mounts [sig-storage][HostCleanup][Flaky]", func() {
ginkgo.Describe("host cleanup with volume mounts [HostCleanup][Flaky]", func() {

type hostCleanupTest struct {
itDescr string
Expand Down