Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies in local node test runner #99899

Merged
merged 1 commit into from May 13, 2021
Merged

Update dependencies in local node test runner #99899

merged 1 commit into from May 13, 2021

Conversation

hasheddan
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates comment on building dependencies step in the local node test
runner to reflect the binaries that are actually produced.

Signed-off-by: hasheddan georgedanielmangum@gmail.com

Which issue(s) this PR fixes:

n/a

Special notes for your reviewer:

We previously built etcd / apiserver / etc. prior to statically linking into a single binary in #30174.

I'll likely follow this up by conditionally building the mounter binary as it is not needed for local runs.

/assign @Random-Liu

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@hasheddan
Update dependencies in local node test runner
b85fbfc 
Updates comment on building dependencies step in the local node test
runner to reflect the binaries that are actually produced.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 6, 2021
@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 6, 2021
@ehashman ehashman added this to Triage in SIG Node CI/Test Board Mar 8, 2021
@ehashman ehashman added this to Triage in SIG Node PR Triage Mar 8, 2021
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to PRs - Review in progress in SIG Node CI/Test Board Mar 10, 2021
@SergeyKanzhelev SergeyKanzhelev moved this from PRs - Review in progress to Triage in SIG Node CI/Test Board Mar 10, 2021
ehashman
ehashman reviewed Mar 10, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/triage accepted
/lgtm
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 10, 2021
@ehashman ehashman moved this from Triage to PRs - Reviewer lgtm'd in SIG Node CI/Test Board Mar 10, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2021
@ehashman
Copy link
Member

/milestone v1.21

Discussed at 2021-03-17 Node CI meeting for test freeze.

@mrunalp
Copy link
Contributor

mrunalp commented Apr 28, 2021

/approve

@SergeyKanzhelev
Copy link
Member

/test pull-kubernetes-node-e2e-containerd

@SergeyKanzhelev
Copy link
Member

/approve

@mrunalp can you pls re-approve, bot has failed to react

@mrunalp
Copy link
Contributor

mrunalp commented May 12, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2021
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

4 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit f35e587 into kubernetes:master May 13, 2021
SIG Node CI/Test Board automation moved this from PRs - Needs Approver to Done May 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman left review comments

@MHBauer MHBauer Awaiting requested review from MHBauer

@vpickard vpickard Awaiting requested review from vpickard

Assignees

@ehashman ehashman

@Random-Liu Random-Liu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Triage
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@hasheddan @ehashman @mrunalp @SergeyKanzhelev @k8s-ci-robot @fejta-bot @Random-Liu