Skip to content

Commit

Permalink
addons: Update Inspektor Gadget entrypoint and cleanup.
Browse files Browse the repository at this point in the history
Inspektor Gadget container entrypoint and cleanup programs were translated from
bash to golang [1, 2].
Upstream YAML file used to deploy was updated to reflect this change [3].

Sadly, it was not the case for the YAML used to deploy the minikube addon which
leaded to troubles [4, 5, 6].

The present commit updates the minikube addon YAML to use the correct programs
as entrypoint and cleanup.

Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
[1]: inspektor-gadget/inspektor-gadget@b268d38
[2]: inspektor-gadget/inspektor-gadget@3dba83f
[3]: inspektor-gadget/inspektor-gadget@992399f#diff-0927404b80a3c13f63de64a0c7af1833ba3dfd4b4e1dd07b09cb8216c7f033fcR46
[4]: https://storage.googleapis.com/minikube-builds/logs/17731/32161/Docker_Linux_crio_arm64.html#fail_TestAddons/parallel/InspektorGadget
[5]: https://storage.googleapis.com/minikube-builds/logs/17731/32161/Docker_Linux_crio.html#fail_TestAddons/parallel/InspektorGadget
[6]: https://storage.googleapis.com/minikube-builds/logs/17731/32161/KVM_Linux_crio.html#fail_TestAddons/parallel/InspektorGadget
  • Loading branch information
eiffel-fl committed Dec 6, 2023
1 parent c56894f commit e9a03cb
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions deploy/addons/inspektor-gadget/ig-daemonset.yaml.tmpl
Expand Up @@ -32,12 +32,12 @@ spec:
terminationMessagePolicy: FallbackToLogsOnError
image: {{.CustomRegistries.InspektorGadget | default .ImageRepository | default .Registries.InspektorGadget }}{{.Images.InspektorGadget}}
imagePullPolicy: "Always"
command: [ "/entrypoint.sh" ]
command: [ "/entrypoint" ]
lifecycle:
preStop:
exec:
command:
- "/cleanup.sh"
- "/cleanup"
readinessProbe:
periodSeconds: 5
timeoutSeconds: 2
Expand Down

0 comments on commit e9a03cb

Please sign in to comment.