Add boolean to disable opening browser during test

The WaitAndMaybeOpenService(..) method allow user to open the service
url in a browser when found, this create issue during testing as it's
opening browser and consuming resources.

The fix is to introduce a boolean flag allowing the caller to specify
whether to just print out the url or open a browser window

cmd/minikube/cmd/config/open.go

@@ -95,7 +95,7 @@ You can add one by annotating a service with the label {{.labelName}}:{{.addonNa
 		}
 		for i := range serviceList.Items {
 			svc := serviceList.Items[i].ObjectMeta.Name
-			if err := service.WaitAndMaybeOpenService(api, namespace, svc, addonsURLTemplate, addonsURLMode, https, wait, interval); err != nil {
+			if err := service.WaitAndMaybeOpenService(api, namespace, svc, addonsURLTemplate, addonsURLMode, https, wait, interval, true); err != nil {
 				exit.WithCodeT(exit.Unavailable, "Wait failed: {{.error}}", out.V{"error": err})
 			}
 		}

cmd/minikube/cmd/service.go

@@ -69,7 +69,7 @@ var serviceCmd = &cobra.Command{
 			os.Exit(1)
 		}
 		err = service.WaitAndMaybeOpenService(api, namespace, svc,
-			serviceURLTemplate, serviceURLMode, https, wait, interval)
+			serviceURLTemplate, serviceURLMode, https, wait, interval, true)
 		if err != nil {
 			exit.WithError("Error opening service", err)
 		}

pkg/minikube/service/service.go

@@ -267,7 +267,7 @@ func PrintServiceList(writer io.Writer, data [][]string) {
 
 // WaitAndMaybeOpenService waits for a service, and opens it when running
 func WaitAndMaybeOpenService(api libmachine.API, namespace string, service string, urlTemplate *template.Template, urlMode bool, https bool,
-	wait int, interval int) error {
+	wait int, interval int, openbrowser bool) error {
 	// Convert "Amount of time to wait" and "interval of each check" to attempts
 	if interval == 0 {
 		interval = 1
@@ -301,7 +301,7 @@ func WaitAndMaybeOpenService(api libmachine.API, namespace string, service strin
 	for _, bareURLString := range serviceURL.URLs {
 		urlString, isHTTPSchemedURL := OptionallyHTTPSFormattedURLString(bareURLString, https)
 
-		if urlMode || !isHTTPSchemedURL {
+		if urlMode || !isHTTPSchemedURL || !openbrowser {
 			out.T(out.Empty, urlString)
 		} else {
 			out.T(out.Celebrate, "Opening kubernetes service  {{.namespace_name}}/{{.service_name}} in default browser...", out.V{"namespace_name": namespace, "service_name": service})

pkg/minikube/service/service_test.go

@@ -903,7 +903,7 @@ func TestWaitAndMaybeOpenService(t *testing.T) {
 				servicesMap:  serviceNamespaces,
 				endpointsMap: endpointNamespaces,
 			}
-			err := WaitAndMaybeOpenService(test.api, test.namespace, test.service, defaultTemplate, test.urlMode, test.https, 1, 0)
+			err := WaitAndMaybeOpenService(test.api, test.namespace, test.service, defaultTemplate, test.urlMode, test.https, 1, 0, false)
 			if test.err && err == nil {
 				t.Fatalf("WaitAndMaybeOpenService expected to fail for test: %v", test)
 			}
@@ -954,7 +954,7 @@ func TestWaitAndMaybeOpenServiceForNotDefaultNamspace(t *testing.T) {
 				servicesMap:  serviceNamespaceOther,
 				endpointsMap: endpointNamespaces,
 			}
-			err := WaitAndMaybeOpenService(test.api, test.namespace, test.service, defaultTemplate, test.urlMode, test.https, 1, 0)
+			err := WaitAndMaybeOpenService(test.api, test.namespace, test.service, defaultTemplate, test.urlMode, test.https, 1, 0, false)
 			if test.err && err == nil {
 				t.Fatalf("WaitAndMaybeOpenService expected to fail for test: %v", test)
 			}