Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test image registry connectivity should also ignore scheme prefixed proxy #10253

Closed
lingsamuel opened this issue Jan 25, 2021 · 5 comments
Closed
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@lingsamuel
Copy link
Contributor

proxy := os.Getenv("HTTPS_PROXY")
if proxy != "" && !strings.HasPrefix(proxy, "localhost") && !strings.HasPrefix(proxy, "127.0") {
opts = append([]string{"-x", proxy}, opts...)
}

image

Could extract a util function from #8885

By the way, I am wondering if we can convert localhost to host machine IP? Or add a flag to replace localhost?

something like: minikube start --host-ip=$(nmcli -g ip4.address dev show eth0)

@lingsamuel lingsamuel changed the title Test image registry should also ignore scheme prefixed proxy Test image registry connectivity should also ignore scheme prefixed proxy Jan 25, 2021
@lingsamuel
Copy link
Contributor Author

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 25, 2021
@priyawadhwa priyawadhwa added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Jan 25, 2021
@sharifelgamal
Copy link
Collaborator

I believe you can set the DOCKER_HOST environment variable and we will honor that IP address instead of localhost.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 13, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 12, 2021
@spowelljr
Copy link
Member

Hi @lingsamuel, you haven't responded to @sharifelgamal's suggestion, so I'm going to close this issue. However, if you try his suggestion and it doesn't work, feel free to reopen the issue, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

6 participants