Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

populate kic.txt properly in kicbase #10408

Merged
merged 39 commits into from
Feb 19, 2021

Conversation

sharifelgamal
Copy link
Collaborator

@sharifelgamal sharifelgamal commented Feb 8, 2021

This is a trivial but legitimate change for the kicbase Dockerfile to test automation requested in #9072

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 8, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 8, 2021
@sharifelgamal sharifelgamal added ok-to-build-image size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 8, 2021
@sharifelgamal
Copy link
Collaborator Author

/ok-to-build-image

@sharifelgamal
Copy link
Collaborator Author

OK to build image

@sharifelgamal
Copy link
Collaborator Author

ok-to-build-image

4 similar comments
@sharifelgamal
Copy link
Collaborator Author

ok-to-build-image

@sharifelgamal
Copy link
Collaborator Author

ok-to-build-image

@sharifelgamal
Copy link
Collaborator Author

ok-to-build-image

@sharifelgamal
Copy link
Collaborator Author

ok-to-build-image

@sharifelgamal
Copy link
Collaborator Author

ok-to-build-image

2 similar comments
@sharifelgamal
Copy link
Collaborator Author

ok-to-build-image

@sharifelgamal
Copy link
Collaborator Author

ok-to-build-image

@sharifelgamal
Copy link
Collaborator Author

ok-to-build-image

1 similar comment
@sharifelgamal
Copy link
Collaborator Author

ok-to-build-image

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 13, 2021
@sharifelgamal
Copy link
Collaborator Author

ok-to-build-image

1 similar comment
@sharifelgamal
Copy link
Collaborator Author

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @sharifelgamal,

A new kicbase image is available, please update your PR with the new tag and SHA.
In pkg/drivers/kic/types.go:

// Version is the current version of kic
Version = "v0.0.17-1613687174-10408"
// SHA of the kic base image
baseImageSHA = ""
// The name of the GCR kicbase repository
gcrRepo = "gcr.io/k8s-minikube/kicbase-builds"
// The name of the Dockerhub kicbase repository
dockerhubRepo = "kicbase/build"

Then run make generate-docs to update our documentation to reference the new image.

Alternatively, run the following command and commit the changes:

 sed 's|Version = .*|Version = "v0.0.17-1613687174-10408"|;s|baseImageSHA = .*|baseImageSHA = ""|;s|gcrRepo = .*|gcrRepo = "gcr.io/k8s-minikube/kicbase-builds"|;s|dockerhubRepo = .*|dockerhubRepo = kicbase/build|' pkg/drivers/kic/types.go > new-types.go; mv new-types.go pkg/drivers/kic/types.go; make generate-docs

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: 72.2s 68.1s 70.9s
Average time for minikube: 70.4s

Times for Minikube (PR 10408): 72.1s 68.1s 68.7s
Average time for Minikube (PR 10408): 69.6s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10408) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.17.1 on Debian               | 0.1s     | 0.0s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 44.0s    | 42.6s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 23.1s    | 23.6s               |
| on Docker 20.10.2 ...                      |          |                     |
|   - Generating certificates                | 0.0s     | 0.0s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 0.0s     | 0.0s                |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 0.6s     | 0.5s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.7s     | 1.5s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.8s     | 1.3s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 29.3s 28.1s 36.4s
Average time for minikube: 31.2s

Times for Minikube (PR 10408): 27.6s 31.2s 26.4s
Average time for Minikube (PR 10408): 28.4s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10408) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.17.1 on Debian               | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 13.7s    | 11.6s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 15.8s    |                     |
| on Docker 20.10.2 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.1s     | 1.2s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

@sharifelgamal
Copy link
Collaborator Author

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @sharifelgamal, building a new kicbase image failed, please try again.

@sharifelgamal
Copy link
Collaborator Author

ok-to-build-image

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: 69.2s 69.6s 70.1s
Average time for minikube: 69.7s

Times for Minikube (PR 10408): 71.3s 69.6s 71.9s
Average time for Minikube (PR 10408): 70.9s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10408) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.17.1 on Debian               | 0.0s     | 0.0s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 43.1s    | 43.7s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 2.2s     | 24.6s               |
| on Docker 20.10.2 ...                      |          |                     |
|   - Generating certificates                | 4.0s     | 0.0s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 16.1s    | 0.0s                |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.6s     | 0.6s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.8s     | 1.6s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.7s     | 0.3s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 28.5s 27.7s 27.4s
Average time for minikube: 27.8s

Times for Minikube (PR 10408): 28.0s 27.2s 27.0s
Average time for Minikube (PR 10408): 27.4s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10408) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.17.1 on Debian               | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 10.2s    | 10.8s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 16.1s    |                     |
| on Docker 20.10.2 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 0.9s     | 1.0s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

@minikube-bot
Copy link
Collaborator

Hi @sharifelgamal,

A new kicbase image is available, please update your PR with the new tag and SHA.
In pkg/drivers/kic/types.go:

// Version is the current version of kic
Version = "v0.0.17-1613688791-10408"
// SHA of the kic base image
baseImageSHA = "b8cea5f43f362e3c8e15a3731df2af7dcd08b82b5cec91feaceab9ad70fbddaf"
// The name of the GCR kicbase repository
gcrRepo = "gcr.io/k8s-minikube/kicbase-builds"
// The name of the Dockerhub kicbase repository
dockerhubRepo = "kicbase/build"

Then run make generate-docs to update our documentation to reference the new image.

Alternatively, run the following command and commit the changes:

 sed 's|Version = .*|Version = "v0.0.17-1613688791-10408"|;s|baseImageSHA = .*|baseImageSHA = "b8cea5f43f362e3c8e15a3731df2af7dcd08b82b5cec91feaceab9ad70fbddaf"|;s|gcrRepo = .*|gcrRepo = "gcr.io/k8s-minikube/kicbase-builds"|;s|dockerhubRepo = .*|dockerhubRepo = kicbase/build|' pkg/drivers/kic/types.go > new-types.go; mv new-types.go pkg/drivers/kic/types.go; make generate-docs

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: 68.2s 70.7s 69.3s
Average time for minikube: 69.4s

Times for Minikube (PR 10408): 66.8s 70.7s 69.0s
Average time for Minikube (PR 10408): 68.8s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10408) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.17.1 on Debian               | 0.0s     | 0.0s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 41.7s    | 41.8s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 10.1s    | 9.5s                |
| on Docker 20.10.2 ...                      |          |                     |
|   - Generating certificates                | 2.8s     | 2.9s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 10.9s    | 10.6s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.3s     | 1.2s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.7s     | 1.7s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.8s     | 1.0s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 28.1s 27.7s 28.1s
Average time for minikube: 28.0s

Times for Minikube (PR 10408): 27.3s 26.9s 27.3s
Average time for Minikube (PR 10408): 27.2s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10408) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.17.1 on Debian               | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 10.1s    | 10.5s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 16.0s    |                     |
| on Docker 20.10.2 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.3s     | 1.3s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

@sharifelgamal
Copy link
Collaborator Author

ok-to-build-image

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: 71.1s 73.8s 68.3s
Average time for minikube: 71.1s

Times for Minikube (PR 10408): 69.8s 71.9s 70.5s
Average time for Minikube (PR 10408): 70.7s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10408) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.17.1 on Debian               | 0.1s     | 0.0s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 43.8s    | 43.0s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 16.6s    | 9.9s                |
| on Docker 20.10.2 ...                      |          |                     |
|   - Generating certificates                | 1.4s     | 2.8s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 5.6s     | 11.1s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 0.9s     | 1.3s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.7s     | 1.8s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.9s     | 0.8s                |
| default-storageclass,                      |          |                     |
| storage-provisioner                        |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 29.0s 27.2s 28.3s
Average time for minikube: 28.2s

Times for Minikube (PR 10408): 63.1s 28.5s 30.0s
Average time for Minikube (PR 10408): 40.5s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10408) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.17.1 on Debian               | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 10.7s    | 13.4s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 15.7s    |                     |
| on Docker 20.10.2 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.2s     | 1.1s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

@minikube-bot
Copy link
Collaborator

Hi @sharifelgamal, building a new kicbase image failed, please try again.

@sharifelgamal
Copy link
Collaborator Author

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @sharifelgamal, building a new kicbase image failed, please try again.

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: 69.4s 69.1s 68.6s
Average time for minikube: 69.0s

Times for Minikube (PR 10408): 70.2s 69.0s 71.4s
Average time for Minikube (PR 10408): 70.2s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10408) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.17.1 on Debian               | 0.0s     | 0.0s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 42.3s    | 42.5s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 2.2s     | 2.4s                |
| on Docker 20.10.2 ...                      |          |                     |
|   - Generating certificates                | 4.3s     | 5.1s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 16.3s    | 15.8s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.4s     | 1.6s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.7s     | 1.7s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.7s     | 0.8s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 28.5s 34.6s 28.4s
Average time for minikube: 30.5s

Times for Minikube (PR 10408): 30.8s 32.6s 27.5s
Average time for Minikube (PR 10408): 30.3s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10408) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.17.1 on Debian               | 0.2s     | 0.5s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 13.0s    | 12.9s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 16.1s    |                     |
| on Docker 20.10.2 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 0.9s     | 1.1s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

@sharifelgamal
Copy link
Collaborator Author

ok-to-build-image

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: 68.6s 72.1s 69.9s
Average time for minikube: 70.2s

Times for Minikube (PR 10408): 68.8s 72.6s 68.3s
Average time for Minikube (PR 10408): 69.9s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10408) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.17.1 on Debian               | 0.0s     | 0.0s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 43.1s    | 43.1s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 10.1s    | 10.0s               |
| on Docker 20.10.2 ...                      |          |                     |
|   - Generating certificates                | 2.6s     | 2.5s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 10.6s    | 10.4s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.3s     | 1.2s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.7s     | 1.8s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.7s     | 0.7s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 27.0s 26.8s 28.2s
Average time for minikube: 27.3s

Times for Minikube (PR 10408): 27.6s 27.6s 28.2s
Average time for Minikube (PR 10408): 27.8s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10408) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.17.1 on Debian               | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 10.5s    | 10.4s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 15.3s    |                     |
| on Docker 20.10.2 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.0s     | 1.0s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

@minikube-bot
Copy link
Collaborator

Hi @sharifelgamal, building a new kicbase image failed, please try again.

@sharifelgamal
Copy link
Collaborator Author

ok-to-build-image

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: 69.1s 72.3s 69.9s
Average time for minikube: 70.4s

Times for Minikube (PR 10408): 72.0s 70.7s 68.5s
Average time for Minikube (PR 10408): 70.4s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10408) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.17.1 on Debian               | 0.0s     | 0.0s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 43.6s    | 43.3s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 9.6s     | 9.0s                |
| on Docker 20.10.2 ...                      |          |                     |
|   - Generating certificates                | 2.4s     | 3.1s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 11.1s    | 11.4s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.3s     | 1.2s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.8s     | 1.7s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.5s     | 0.6s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 28.3s 34.8s 26.9s
Average time for minikube: 30.0s

Times for Minikube (PR 10408): 29.5s 27.0s 27.4s
Average time for Minikube (PR 10408): 28.0s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10408) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.17.1 on Debian               | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 12.8s    | 10.6s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 15.6s    |                     |
| on Docker 20.10.2 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.1s     | 0.9s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

@minikube-bot
Copy link
Collaborator

Hi @sharifelgamal,

A new kicbase image is available, please update your PR with the new tag and SHA.
In pkg/drivers/kic/types.go:

// Version is the current version of kic
Version = "v0.0.17-1613701030-10408"
// SHA of the kic base image
baseImageSHA = "d9d270eb0af8fd98fa3f4ca5363ad026dc7119d213df933434b7cd273554971e"
// The name of the GCR kicbase repository
gcrRepo = "gcr.io/k8s-minikube/kicbase-builds"
// The name of the Dockerhub kicbase repository
dockerhubRepo = "kicbase/build"

Then run make generate-docs to update our documentation to reference the new image.

Alternatively, run the following command and commit the changes:

 sed 's|Version = .*|Version = "v0.0.17-1613701030-10408"|;s|baseImageSHA = .*|baseImageSHA = "d9d270eb0af8fd98fa3f4ca5363ad026dc7119d213df933434b7cd273554971e"|;s|gcrRepo = .*|gcrRepo = "gcr.io/k8s-minikube/kicbase-builds"|;s|dockerhubRepo = .*|dockerhubRepo = "kicbase/build"|' pkg/drivers/kic/types.go > new-types.go; mv new-types.go pkg/drivers/kic/types.go; make generate-docs;

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: 73.6s 71.5s 71.2s
Average time for minikube: 72.1s

Times for Minikube (PR 10408): 71.3s 70.7s 73.0s
Average time for Minikube (PR 10408): 71.7s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10408) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.17.1 on Debian               | 0.1s     | 0.1s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the kvm2 driver based              | 0.0s     | 0.0s                |
| on user configuration                      |          |                     |
| * Starting control plane node              | 0.0s     | 0.0s                |
| minikube in cluster minikube               |          |                     |
| * Creating kvm2 VM (CPUs=2,                | 44.0s    | 43.5s               |
| Memory=3700MB, Disk=20000MB)               |          |                     |
| ...                                        |          |                     |
| * Preparing Kubernetes v1.20.2             | 2.1s     | 2.1s                |
| on Docker 20.10.2 ...                      |          |                     |
|   - Generating certificates                | 5.7s     | 5.6s                |
| and keys ...                               |          |                     |
|   - Booting up control plane               | 16.2s    | 16.5s               |
| ...                                        |          |                     |
|   - Configuring RBAC rules ...             | 1.7s     | 1.4s                |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.7s     | 1.6s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.7s     | 1.2s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

docker Driver
Times for minikube: 28.3s 27.5s 28.1s
Average time for minikube: 27.9s

Times for Minikube (PR 10408): 27.9s 27.7s 27.8s
Average time for Minikube (PR 10408): 27.8s

Averages Time Per Log

+--------------------------------------------+----------+---------------------+
|                    LOG                     | MINIKUBE | MINIKUBE (PR 10408) |
+--------------------------------------------+----------+---------------------+
| * minikube v1.17.1 on Debian               | 0.2s     | 0.2s                |
| 9.11 (kvm/amd64)                           |          |                     |
| * Using the docker driver                  | 0.1s     | 0.1s                |
| based on user configuration                |          |                     |
| * Starting control plane node              | 0.1s     | 0.1s                |
| minikube in cluster minikube               |          |                     |
| * Creating docker container                | 10.8s    | 10.4s               |
| (CPUs=2, Memory=3700MB) ...                |          |                     |
| * Preparing Kubernetes v1.20.2             | 15.5s    |                     |
| on Docker 20.10.2 ...                      |          |                     |
| * Verifying Kubernetes                     | 0.1s     | 0.1s                |
| components...                              |          |                     |
|   - Using image                            | 1.1s     | 0.9s                |
| gcr.io/k8s-minikube/storage-provisioner:v4 |          |                     |
| * Enabled addons:                          | 0.1s     | 0.1s                |
| storage-provisioner,                       |          |                     |
| default-storageclass                       |          |                     |
| * Done! kubectl is now                     | 0.0s     | 0.0s                |
| configured to use "minikube"               |          |                     |
| cluster and "default"                      |          |                     |
| namespace by default                       |          |                     |
+--------------------------------------------+----------+---------------------+

@sharifelgamal sharifelgamal merged commit 96c5b6a into kubernetes:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants