Enhance service command to support multiple services

[darkedges]

It would be great to see
https://github.com/txn2/kubefwd incorporated so that you can forward all services in a namespace in a single request.

This would help those running within docker where metallb does not work due to the host not being able to NAT requests into the kubernetes container. Other examples are when you have multiple services and need to implement multiple shells and commands to handle the port forward / services requests.

[spowelljr]

Hi @darkedges, thanks for the suggestion! We're open to any PR's that implement this!

[ckannon]

@spowelljr I'd be happy to take this one. From a design perspective, any ideas on how we want this to work? kubefwd supports quite a few flags. Maybe MVP for this feature would be just supporting forwarding all services in a namespace (-n) and all services in a namespace with label selectors (-l labelname=foo,labelname=bar)?

[ckannon]

/assign

[medyagh]

I am not sure how the implementation would work, but I would be okay with a design that could make it work as long as the user doesnt have to install anything extra

maybe something like "minikube service --all" could be a good idea to forward all services instead of just one

@ckannon please feel free to take a stab at it

[ckannon]

Awesome, that's what I was thinking as well.. I don't want to include the library, more so, some of the functionality.

…

On Wed, Jan 12, 2022 at 2:39 PM Medya Ghazizadeh ***@***.***> wrote: I am not sure how the implementation would work, but I would be okay with a design that could make it work as long as the user doesnt have to install anything extra maybe something like "minikube service --all" could be a good idea to forward all services instead of just one @ckannon <https://github.com/ckannon> please feel free to take a stab at it — Reply to this email directly, view it on GitHub <#13075 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AS2EZY2TUMRFDJ4ZBUZRCOLUVXKIXANCNFSM5JJA6YRQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[medyagh]

thank you @ckannon if u dont mind adding it as a PR on minikube repo so I could review that way

[ckannon]

Already done, PR is here: 3629b50

…

On Tue, Jan 18, 2022 at 1:38 PM Medya Ghazizadeh ***@***.***> wrote: thank you @ckannon <https://github.com/ckannon> if u dont mind adding it as a PR on minikube repo so I could review that way — Reply to this email directly, view it on GitHub <#13075 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AS2EZY2XPXQZEQV2KVKEWHLUWWXSXANCNFSM5JJA6YRQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[medyagh]

here is the link to the binary from a PR that I think might fix this issue, do you mind trying it out ?

https://storage.googleapis.com/minikube-builds/13756/minikube-linux-amd64
https://storage.googleapis.com/minikube-builds/13756/minikube-darwin-amd64
https://storage.googleapis.com/minikube-builds/13756/minikube-windows-amd64.exe