Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output message if user tries to enable addons with --no-kubernetes #13487

Closed
spowelljr opened this issue Jan 25, 2022 · 9 comments · Fixed by #15003
Closed

Output message if user tries to enable addons with --no-kubernetes #13487

spowelljr opened this issue Jan 25, 2022 · 9 comments · Fixed by #15003
Assignees
@NikhilSharmaWe
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/improvement Categorizes issue or PR as related to improving upon a current feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-solution-message Issues where where offering a solution for an error would be helpful priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@spowelljr
Copy link
Member

spowelljr commented Jan 25, 2022 •
edited

It's not possible to enable addons with --no-kubernetes passed because the addons in their current state are deployed to Kubernetes. So if a user tries to enable an addon with --no-kubernetes output a message notifying them that it's not possible without Kubernetes and exit execution.

Related #13461
@spowelljr spowelljr added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. needs-solution-message Issues where where offering a solution for an error would be helpful kind/improvement Categorizes issue or PR as related to improving upon a current feature. labels Jan 25, 2022
@charego charego mentioned this issue Jan 25, 2022
Closed
@NikhilSharmaWe
Copy link
Member

@spowelljr I would like to work on it, could you please give me some code pointers or inform about where in the repo the changes are needed.

@SilkeDH
Copy link

SilkeDH commented Jan 27, 2022 •
edited

@NikhilSharmaWe I would suggest you to check these files: start_flags.go and start.go. There is a function in start.go called validateFlags(args) which validates the flags, you probably need to add another condition which invalidates the user to add addons while not using kubernetes.

@spowelljr
Copy link
Member Author

spowelljr commented Jan 27, 2022 •
edited

@NikhilSharmaWe This is where the minikube addons enable <addon> logic gets called initially https://github.com/kubernetes/minikube/blob/master/cmd/minikube/cmd/config/enable.go. You can run the command config.Load(ClusterFlagValue()) to get the existing cluster config and check if --no-kubernetes is set, and if it is just exit with the message.

@NikhilSharmaWe NikhilSharmaWe mentioned this issue Jan 28, 2022
Closed
@spowelljr spowelljr added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Feb 16, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 17, 2022
@NikhilSharmaWe
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 17, 2022
@deepto98
Copy link

Can I pick this up, if its still open?

@klaases
Copy link
Contributor

klaases commented Sep 7, 2022

Hi @NikhilSharmaWe, are you still working on this?

@deepto98, are you still interested in working on this?

@kpiljoong kpiljoong mentioned this issue Sep 22, 2022
Merged
@Aut0R3V
Copy link
Contributor

Aut0R3V commented Nov 7, 2022

Hey, anyone working on this?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikhilSharmaWe NikhilSharmaWe

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/improvement Categorizes issue or PR as related to improving upon a current feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-solution-message Issues where where offering a solution for an error would be helpful priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
8 participants
@k8s-ci-robot @spowelljr @k8s-triage-robot @SilkeDH @Aut0R3V @NikhilSharmaWe @deepto98 @klaases