Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License Scan Report #15425

Open
spowelljr opened this issue Nov 29, 2022 · 8 comments
Open

License Scan Report #15425

spowelljr opened this issue Nov 29, 2022 · 8 comments
Labels
kind/improvement Categorizes issue or PR as related to improving upon a current feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@spowelljr
Copy link
Member

spowelljr commented Nov 29, 2022

https://lfscanning.org/reports/cncf/kubernetes-2022-10-13-19a6e7e7-4f53-4c58-9dcb-6ab28ebf194d.html

Minikube has 7 licenses that came up in the report

This code is under the GPL license and could contaminate the entire codebase, it must be removed from the repo.

kubernetes-2022-10-13.zip/minikube/deploy/iso/minikube-iso/package/crun/crun.mk
kubernetes-2022-10-13.zip/minikube/deploy/iso/minikube-iso/package/pahole/pahole.mk
kubernetes-2022-10-13.zip/minikube/deploy/iso/minikube-iso/package/sysdig/sysdig.mk

This file lists the license as "Apache", but doesn't specify which version. Could this be updated to "Apache-2.0" in order to be clearer?

kubernetes-2022-10-13.zip/minikube/installers/linux/archlinux-driver/.SRCINFO
kubernetes-2022-10-13.zip/minikube/installers/linux/archlinux-driver/PKGBUILD
kubernetes-2022-10-13.zip/minikube/installers/linux/archlinux/.SRCINFO
kubernetes-2022-10-13.zip/minikube/installers/linux/archlinux/PKGBUILD
@spowelljr spowelljr added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/improvement Categorizes issue or PR as related to improving upon a current feature. labels Nov 29, 2022
@spowelljr
Copy link
Member Author

The latter four are our own files, so updating to Apache-2.0 isn't an issue

@k8s-triage-robot

This comment was marked as outdated.

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 27, 2023
@afbjorklund
Copy link
Collaborator

afbjorklund commented Feb 27, 2023

@spowelljr : the ISO license is different from the minikube license. There are many GPL components, on the ISO.

If you want a full summary of all licenses and all patches, there is a legal-info build target that could be used ?

With the exceptions below, Buildroot is distributed under the terms of
the GNU General Public License, reproduced below; either version 2 of
the License, or (at your option) any later version.

Some files in Buildroot contain a different license statement. Those
files are licensed under the license contained in the file itself.

https://buildroot.org/downloads/manual/manual.html#legal-info

@afbjorklund
Copy link
Collaborator

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 27, 2023
@afbjorklund
Copy link
Collaborator

afbjorklund commented Feb 27, 2023

For the KIC base, you could use something like https://github.com/daald/dpkg-licenses

It is supposed to generate a list of all the .deb files that are installed by our Dockerfile ?

@afbjorklund
Copy link
Collaborator

Note that the "LICENSE" line is not related to the packaging, or the minikube code.

It just describes the software being packaged, so it is just metadata for the package.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 28, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Categorizes issue or PR as related to improving upon a current feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

4 participants