Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matching Kubernetes Version for crictl to the preload #18359

Open
medyagh opened this issue Mar 11, 2024 · 5 comments · May be fixed by #18362
Open

Add matching Kubernetes Version for crictl to the preload #18359

medyagh opened this issue Mar 11, 2024 · 5 comments · May be fixed by #18362
Assignees
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@medyagh
Copy link
Member

medyagh commented Mar 11, 2024

What Happened?

starting kubernetes v1.29 we need to have matching crictl and cni plugin

First we need extact preload
so we first check if crictl and kubernets version are same
then nothing
if not download and install matching crictl on the fly

so also need to add the crictl to the preload generation scriipt

@medyagh medyagh added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Mar 11, 2024
@afbjorklund
Copy link
Collaborator

This needs to be added / moved to the bootstrapper, so that it also works for --preload=false.

But it is supposed to be able to install them, similar to how it installs kubeadm/kubelet/kubectl today.

@afbjorklund
Copy link
Collaborator

Previously it was checking (in minikube start) for crictl to be installed on the OS, for all versions.

But that approach doesn't work since Kubernetes 1.28, now you need separate versions for each

@afbjorklund
Copy link
Collaborator

afbjorklund commented Mar 11, 2024

https://github.com/kubernetes/release/blob/master/cmd/krel/templates/latest/metadata.yaml

k8s cri cni
1.26.0 >= 1.25.0 >= 1.1.1
1.27.0 >= 1.25.0 >= 1.1.1
1.28.0 >= 1.28.0 >= 1.1.1
1.29.0 >= 1.28.0 >= 1.2.0
1.30.0 >= 1.30.0 >= 1.2.0

@afbjorklund
Copy link
Collaborator

afbjorklund commented Mar 11, 2024

Note that the crictl version doesn't exactly match the kubeadm version, last digit might differ.

@ComradeProgrammer
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants