Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kicbase: Revert cri-o from v1.29 to v1.24 #18367

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Mar 12, 2024

As discussed during office hours and as evidenced in #18294, using newer crictl and cri-o versions results in incompatibility with previous Kubernetes versions. Rolling back until we implement a mechanism to use the matching cri-o and crictl versions to the chosen Kubernetes version (#18359).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 12, 2024
@spowelljr
Copy link
Member Author

ok-to-build-image

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 12, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2024
@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18367) |
+----------------+----------+---------------------+
| minikube start | 51.2s    | 52.5s               |
| enable ingress | 25.4s    | 25.4s               |
+----------------+----------+---------------------+

Times for minikube start: 49.7s 52.6s 52.5s 49.3s 51.7s
Times for minikube (PR 18367) start: 52.3s 54.1s 53.6s 52.7s 49.9s

Times for minikube ingress: 27.0s 25.6s 25.2s 23.1s 26.2s
Times for minikube (PR 18367) ingress: 25.2s 26.6s 25.6s 26.7s 23.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18367) |
+----------------+----------+---------------------+
| minikube start | 24.8s    | 23.6s               |
| enable ingress | 20.7s    | 20.3s               |
+----------------+----------+---------------------+

Times for minikube start: 25.7s 23.3s 24.9s 26.3s 23.6s
Times for minikube (PR 18367) start: 22.5s 23.4s 26.7s 22.7s 22.6s

Times for minikube ingress: 23.3s 19.3s 20.3s 20.3s 20.3s
Times for minikube (PR 18367) ingress: 20.3s 20.3s 20.3s 20.3s 20.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18367) |
+----------------+----------+---------------------+
| minikube start | 24.0s    | 23.5s               |
| enable ingress | 34.2s    | 33.8s               |
+----------------+----------+---------------------+

Times for minikube start: 24.3s 23.9s 24.3s 24.0s 23.5s
Times for minikube (PR 18367) start: 24.2s 24.3s 21.9s 24.8s 22.4s

Times for minikube ingress: 30.8s 31.8s 30.8s 30.8s 46.8s
Times for minikube (PR 18367) ingress: 29.8s 31.8s 29.8s 46.8s 30.8s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux TestFunctional/parallel/ConfigCmd (gopogh) 1.20 (chart)
KVM_Linux TestNoKubernetes/serial/StartNoArgs (gopogh) 2.16 (chart)
KVM_Linux_containerd TestAddons/parallel/HelmTiller (gopogh) 3.01 (chart)
Docker_Linux_crio_arm64 TestMutliControlPlane/serial/RestartCluster (gopogh) 13.85 (chart)
Docker_Linux_containerd_arm64 TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 19.88 (chart)

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit 168f975 into kubernetes:master Mar 12, 2024
25 of 41 checks passed
@spowelljr spowelljr deleted the revertCrioKicbase branch March 12, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants