Commit 7a9f3be reverted vendor change of PR 1798

[huguesalary]

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

PR #1881 just canceled PR #1798

That is, PR #1798 updated the vendored github.com/spf13/viper from revision 7fb2782df3d83e0036cc89f461ed0422628776f4 to 25b30aa063fc18e48662b86996252eabdcf2f0c7, to fix a bug reported in #1797

PR #1881 just reverted back to 7fb2782df3d83e0036cc89f461ed0422628776f4

[huguesalary]

Actually, PR #1881 is not the problematic commit.

Commit 7a9f3bef0d49ec8747e699e82327500f94ed3aa3 (Upgrade to Kubernetes v1.7.5) is the issue.

[r2d4]

This is due to the script which prioritizes upstream kubernetes/kubernetes dependencies over ours in the case of a conflict. We'll need to add a step to the restore script to make sure we still checkout the correct version of viper.

https://github.com/kubernetes/minikube/blob/master/hack/godeps/godep-restore.sh

[huguesalary]

Cool that's good to know.

I'd help modifying this script, but I'm not sure what I'd need to do.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close