Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outdated version of spf13/viper prevents use of viper.StringSlice() #1797

Closed
huguesalary opened this issue Aug 7, 2017 · 0 comments · Fixed by #1798 or #1857
Closed

outdated version of spf13/viper prevents use of viper.StringSlice() #1797

huguesalary opened this issue Aug 7, 2017 · 0 comments · Fixed by #1798 or #1857
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@huguesalary
Copy link
Contributor

BUG REPORT

Minikube version (use minikube version): v0.21.0

Environment:

  • OS: OSX El Capitan 10.11.6
  • VM Driver: xhyve

What happened:
I am currently developing a feature for minikube that requires the use of viper.StringSlice() and/or viper.StringSliceVar().

Unfortunately, the current vendored revision of github.com/spf13/viper is 7fb2782df3d83e0036cc89f461ed0422628776f4 which contains a bug preventing the use of viper.StringSlice(), viper.StringSliceVar() and viper.GetStringSlice().

This bug was fixed on April 17 2017 via this PR

It'd be awesome to update the vendored version of github.com/spf13/viper.

huguesalary added a commit to betabrand/minikube that referenced this issue Aug 7, 2017
The previous vendored `github.com/spf13/viper` had this bug spf13/viper#296 .

This commit upgrades to the latest `github.com/spf13/viper` and closes kubernetes#1797.
@r2d4 r2d4 added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 8, 2017
@r2d4 r2d4 closed this as completed in #1798 Aug 8, 2017
r2d4 pushed a commit to r2d4/minikube that referenced this issue Aug 21, 2017
The previous vendored `github.com/spf13/viper` had this bug spf13/viper#296 .

This commit upgrades to the latest `github.com/spf13/viper` and closes kubernetes#1797.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
2 participants